Skip to content

Commit 7503f0c

Browse files
authored
Use forked jemalloc pprof and disable parca-debuginfo stripping (#4328)
1 parent e73eb3e commit 7503f0c

File tree

4 files changed

+51
-75
lines changed

4 files changed

+51
-75
lines changed

Cargo.lock

Lines changed: 34 additions & 61 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/node/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ tonic = { workspace = true, features = ["gzip", "zstd"] }
8080
tracing = { workspace = true }
8181

8282
[target.'cfg(not(target_env = "msvc"))'.dependencies]
83-
jemalloc_pprof = { version = "0.8.1", default-features = false, features = ["symbolize"] }
83+
# forked version while we wait for an upstream release of https://github.com/polarsignals/rust-jemalloc-pprof/pull/31
84+
jemalloc_pprof = { git = "https://github.com/restatedev/rust-jemalloc-pprof", branch = "max-limit", default-features = false, features = ["symbolize"] }
8485
tikv-jemalloc-ctl = { workspace = true }
8586
tikv-jemalloc-sys = { workspace = true }
8687

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ RUN --mount=type=secret,id=parca --mount=type=cache,target=/var/cache/sccache \
9696
$(just --set arch $TARGETARCH --evaluate _arch)-linux-gnu-objcopy --add-gnu-debuglink=target/restate-server.debug target/restate-server && \
9797
$(just --set arch $TARGETARCH --evaluate _arch)-linux-gnu-objcopy --strip-debug target/restatectl && \
9898
$(just --set arch $TARGETARCH --evaluate _arch)-linux-gnu-objcopy --strip-debug target/restate && \
99-
parca-debuginfo upload --store-address=grpc.polarsignals.com:443 --bearer-token-file=/run/secrets/parca target/restate-server.debug && \
99+
parca-debuginfo upload --store-address=grpc.polarsignals.com:443 --bearer-token-file=/run/secrets/parca --no-extract --type=debuginfo target/restate-server.debug && \
100100
rm target/restate-server.debug
101101
RUN cp docker/scripts/download-restate-debug-symbols.sh target/ && \
102102
sed -i"" "s/BUILD_ID/$($(just --set arch $TARGETARCH --evaluate _arch)-linux-gnu-readelf -n target/restate-server | awk '/Build/{print $3}')/g" target/download-restate-debug-symbols.sh

0 commit comments

Comments
 (0)