Bump Rust to 1.92

As part of upgrading Rust to 1.92, this commit removes a couple of unused imports.

Additionally, we temporarily allow the unused-assignments warning which is generated
by fields of errors that are being used by thiserror error messages (via the error
attribute).

Author: tillrohrmann

Cargo.toml

@@ -29,7 +29,7 @@ resolver = "2"
 version = "1.6.0-dev"
 authors = ["restate.dev"]
 edition = "2024"
-rust-version = "1.91.0"
+rust-version = "1.92.0"
 license = "BUSL-1.1"
 repository = "https://github.com/restatedev/restate"
 homepage = "https://github.com/restatedev/restate"
@@ -298,3 +298,8 @@ opt-level = 2
 # The profile that 'dist' will build with
 [profile.dist]
 inherits = "release"
+
+[workspace.lints.rust]
+# Temporarily allow unused assignments until https://github.com/rust-lang/rust/issues/147648 has been fixed.
+# The problem is that error fields used by thiserror::error attribute generate false positives for unused_assignments.
+unused_assignments = "allow"

crates/admin/Cargo.toml

@@ -81,3 +81,6 @@ restate-types = { workspace = true, features = ["test-util"] }
 googletest = { workspace = true }
 test-log = { workspace = true }
 tracing = { workspace = true }
+
+[lints]
+workspace = true

crates/admin/src/cluster_controller/service.rs

@@ -23,7 +23,7 @@ use rand::seq::IteratorRandom;
 use tokio::sync::{mpsc, oneshot};
 use tokio::time;
 use tokio::time::{Instant, Interval, MissedTickBehavior};
-use tracing::{debug, info, warn};
+use tracing::{debug, info};
 
 use restate_bifrost::{Bifrost, MaybeSealedSegment};
 use restate_core::network::tonic_service_filter::{TonicServiceFilter, WaitForReady};

crates/admin/src/service.rs

@@ -15,7 +15,7 @@ use http::{Request, Response, StatusCode};
 use tower::ServiceBuilder;
 use tower_http::classify::ServerErrorsFailureClass;
 use tower_http::trace::TraceLayer;
-use tracing::{Span, debug, error, info, info_span};
+use tracing::{Span, debug, info, info_span};
 
 use restate_admin_rest_model::version::AdminApiVersion;
 use restate_bifrost::Bifrost;

crates/codederror/Cargo.toml

@@ -13,4 +13,7 @@ restate-workspace-hack = { workspace = true }
 codederror-derive = { version = "0.1.0", path = "derive" }
 
 [dev-dependencies]
-thiserror = { workspace = true }
+thiserror = { workspace = true }
+
+[lints]
+workspace = true

crates/core/src/task_center/builder.rs

@@ -10,8 +10,6 @@
 
 use std::sync::atomic::{AtomicUsize, Ordering};
 
-use tracing::error;
-
 use restate_types::config::CommonOptions;
 
 use super::{OwnedHandle, TaskCenterInner};

crates/core/src/task_center/extensions.rs

@@ -157,6 +157,8 @@ where
     F: Future<Output = O>,
 {
     fn with_metadata(self, metadata: &Metadata) -> WithMetadata<Self> {
+        // temporary mute until overrides include more fields
+        #[allow(unused_variables)]
         let current_overrides = OVERRIDES.try_with(Clone::clone).unwrap_or_default();
         // temporary mute until overrides include more fields
         #[allow(clippy::needless_update)]

crates/invoker-impl/src/lib.rs

@@ -33,8 +33,8 @@ use metrics::counter;
 use restate_futures_util::concurrency::Permit;
 use tokio::sync::mpsc;
 use tokio::task::{AbortHandle, JoinSet};
+use tracing::instrument;
 use tracing::{debug, trace, warn};
-use tracing::{error, instrument};
 
 use restate_core::cancellation_watcher;
 use restate_errors::warn_it;

crates/metadata-server/src/raft/network/networking.rs

@@ -17,7 +17,7 @@ use tokio::sync::mpsc;
 use tokio_stream::wrappers::ReceiverStream;
 use tonic::IntoStreamingRequest;
 use tonic::metadata::MetadataValue;
-use tracing::{debug, trace};
+use tracing::trace;
 
 use restate_core::network::net_util;
 use restate_core::{ShutdownError, TaskCenter, TaskHandle, TaskKind};

crates/metadata-server/src/raft/server.rs

@@ -19,7 +19,7 @@ use protobuf::ProtobufError;
 use raft_proto::eraftpb::Message;
 use std::sync::Arc;
 use tokio::sync::{mpsc, watch};
-use tracing::{debug, error};
+use tracing::debug;
 
 use restate_core::network::NetworkServerBuilder;
 use restate_core::{Metadata, MetadataWriter, ShutdownError, cancellation_watcher};