Overhaul error handling/reporting (#554)

* Update the shared core, fix bad error related_command_index with run proposals

* Decorate errors for non completable commands

* Decorate errors for restate promises results

* Update sdk-shared-core

* Revert examples

Author: slinkydeveloper

package-lock.json

@@ -16,6 +16,27 @@ export enum LogLevel {
   WARN = 3,
   ERROR = 4,
 }
+export enum WasmCommandType {
+  Input = 0,
+  Output = 1,
+  GetState = 2,
+  GetStateKeys = 3,
+  SetState = 4,
+  ClearState = 5,
+  ClearAllState = 6,
+  GetPromise = 7,
+  PeekPromise = 8,
+  CompletePromise = 9,
+  Sleep = 10,
+  Call = 11,
+  OneWayCall = 12,
+  SendSignal = 13,
+  Run = 14,
+  AttachInvocation = 15,
+  GetInvocationOutput = 16,
+  CompleteAwakeable = 17,
+  CancelInvocation = 18,
+}
 export interface WasmFailure {
     code: number;
     message: string;
@@ -79,6 +100,8 @@ export class WasmVM {
   notify_input(buffer: Uint8Array): void;
   notify_input_closed(): void;
   notify_error(error_message: string, stacktrace?: string | null): void;
+  notify_error_for_next_command(error_message: string, stacktrace: string | null | undefined, wasm_command_type: WasmCommandType): void;
+  notify_error_for_specific_command(error_message: string, stacktrace: string | null | undefined, wasm_command_type: WasmCommandType, command_index: number, command_name?: string | null): void;
   take_output(): any;
   is_ready_to_execute(): boolean;
   is_completed(handle: number): boolean;
@@ -105,10 +128,11 @@ export class WasmVM {
   sys_run(name: string): number;
   propose_run_completion_success(handle: number, buffer: Uint8Array): void;
   propose_run_completion_failure(handle: number, value: WasmFailure): void;
-  propose_run_completion_failure_transient(handle: number, error_message: string, error_stacktrace: string | null | undefined, attempt_duration: bigint, config: WasmExponentialRetryConfig): void;
+  propose_run_completion_failure_transient(handle: number, error_message: string, error_stacktrace: string | null | undefined, attempt_duration: bigint, config?: WasmExponentialRetryConfig | null): void;
   sys_cancel_invocation(target_invocation_id: string): void;
   sys_write_output_success(buffer: Uint8Array): void;
   sys_write_output_failure(value: WasmFailure): void;
   sys_end(): void;
   is_processing(): boolean;
+  last_command_index(): number;
 }

packages/restate-sdk-cloudflare-workers/patches/vm/sdk_shared_core_wasm_bindings.d.ts

@@ -263,6 +263,30 @@ export const LogLevel = Object.freeze({
     WARN: 3, "3": "WARN",
     ERROR: 4, "4": "ERROR",
 });
+/**
+ * @enum {0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12 | 13 | 14 | 15 | 16 | 17 | 18}
+ */
+export const WasmCommandType = Object.freeze({
+    Input: 0, "0": "Input",
+    Output: 1, "1": "Output",
+    GetState: 2, "2": "GetState",
+    GetStateKeys: 3, "3": "GetStateKeys",
+    SetState: 4, "4": "SetState",
+    ClearState: 5, "5": "ClearState",
+    ClearAllState: 6, "6": "ClearAllState",
+    GetPromise: 7, "7": "GetPromise",
+    PeekPromise: 8, "8": "PeekPromise",
+    CompletePromise: 9, "9": "CompletePromise",
+    Sleep: 10, "10": "Sleep",
+    Call: 11, "11": "Call",
+    OneWayCall: 12, "12": "OneWayCall",
+    SendSignal: 13, "13": "SendSignal",
+    Run: 14, "14": "Run",
+    AttachInvocation: 15, "15": "AttachInvocation",
+    GetInvocationOutput: 16, "16": "GetInvocationOutput",
+    CompleteAwakeable: 17, "17": "CompleteAwakeable",
+    CancelInvocation: 18, "18": "CancelInvocation",
+});
 
 const WasmHeaderFinalization = (typeof FinalizationRegistry === 'undefined')
     ? { register: () => {}, unregister: () => {} }
@@ -567,6 +591,34 @@ export class WasmVM {
         var len1 = WASM_VECTOR_LEN;
         wasm.wasmvm_notify_error(this.__wbg_ptr, ptr0, len0, ptr1, len1);
     }
+    /**
+     * @param {string} error_message
+     * @param {string | null | undefined} stacktrace
+     * @param {WasmCommandType} wasm_command_type
+     */
+    notify_error_for_next_command(error_message, stacktrace, wasm_command_type) {
+        const ptr0 = passStringToWasm0(error_message, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
+        const len0 = WASM_VECTOR_LEN;
+        var ptr1 = isLikeNone(stacktrace) ? 0 : passStringToWasm0(stacktrace, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
+        var len1 = WASM_VECTOR_LEN;
+        wasm.wasmvm_notify_error_for_next_command(this.__wbg_ptr, ptr0, len0, ptr1, len1, wasm_command_type);
+    }
+    /**
+     * @param {string} error_message
+     * @param {string | null | undefined} stacktrace
+     * @param {WasmCommandType} wasm_command_type
+     * @param {number} command_index
+     * @param {string | null} [command_name]
+     */
+    notify_error_for_specific_command(error_message, stacktrace, wasm_command_type, command_index, command_name) {
+        const ptr0 = passStringToWasm0(error_message, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
+        const len0 = WASM_VECTOR_LEN;
+        var ptr1 = isLikeNone(stacktrace) ? 0 : passStringToWasm0(stacktrace, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
+        var len1 = WASM_VECTOR_LEN;
+        var ptr2 = isLikeNone(command_name) ? 0 : passStringToWasm0(command_name, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
+        var len2 = WASM_VECTOR_LEN;
+        wasm.wasmvm_notify_error_for_specific_command(this.__wbg_ptr, ptr0, len0, ptr1, len1, wasm_command_type, command_index, ptr2, len2);
+    }
     /**
      * @returns {any}
      */
@@ -906,14 +958,14 @@ export class WasmVM {
      * @param {string} error_message
      * @param {string | null | undefined} error_stacktrace
      * @param {bigint} attempt_duration
-     * @param {WasmExponentialRetryConfig} config
+     * @param {WasmExponentialRetryConfig | null} [config]
      */
     propose_run_completion_failure_transient(handle, error_message, error_stacktrace, attempt_duration, config) {
         const ptr0 = passStringToWasm0(error_message, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
         const len0 = WASM_VECTOR_LEN;
         var ptr1 = isLikeNone(error_stacktrace) ? 0 : passStringToWasm0(error_stacktrace, wasm.__wbindgen_malloc, wasm.__wbindgen_realloc);
         var len1 = WASM_VECTOR_LEN;
-        const ret = wasm.wasmvm_propose_run_completion_failure_transient(this.__wbg_ptr, handle, ptr0, len0, ptr1, len1, attempt_duration, config);
+        const ret = wasm.wasmvm_propose_run_completion_failure_transient(this.__wbg_ptr, handle, ptr0, len0, ptr1, len1, attempt_duration, isLikeNone(config) ? 0 : addToExternrefTable0(config));
         if (ret[1]) {
             throw takeFromExternrefTable0(ret[0]);
         }
@@ -962,6 +1014,13 @@ export class WasmVM {
         const ret = wasm.wasmvm_is_processing(this.__wbg_ptr);
         return ret !== 0;
     }
+    /**
+     * @returns {number}
+     */
+    last_command_index() {
+        const ret = wasm.wasmvm_last_command_index(this.__wbg_ptr);
+        return ret;
+    }
 }
 
 export function __wbg_String_eecc4a11987127d6(arg0, arg1) {

packages/restate-sdk-cloudflare-workers/patches/vm/sdk_shared_core_wasm_bindings_bg.js

@@ -19,6 +19,8 @@ export const wasmvm_get_response_head: (a: number) => number;
 export const wasmvm_notify_input: (a: number, b: number, c: number) => void;
 export const wasmvm_notify_input_closed: (a: number) => void;
 export const wasmvm_notify_error: (a: number, b: number, c: number, d: number, e: number) => void;
+export const wasmvm_notify_error_for_next_command: (a: number, b: number, c: number, d: number, e: number, f: number) => void;
+export const wasmvm_notify_error_for_specific_command: (a: number, b: number, c: number, d: number, e: number, f: number, g: number, h: number, i: number) => void;
 export const wasmvm_take_output: (a: number) => any;
 export const wasmvm_is_ready_to_execute: (a: number) => [number, number, number];
 export const wasmvm_is_completed: (a: number, b: number) => number;
@@ -45,12 +47,13 @@ export const wasmvm_sys_complete_promise_failure: (a: number, b: number, c: numb
 export const wasmvm_sys_run: (a: number, b: number, c: number) => [number, number, number];
 export const wasmvm_propose_run_completion_success: (a: number, b: number, c: number, d: number) => [number, number];
 export const wasmvm_propose_run_completion_failure: (a: number, b: number, c: any) => [number, number];
-export const wasmvm_propose_run_completion_failure_transient: (a: number, b: number, c: number, d: number, e: number, f: number, g: bigint, h: any) => [number, number];
+export const wasmvm_propose_run_completion_failure_transient: (a: number, b: number, c: number, d: number, e: number, f: number, g: bigint, h: number) => [number, number];
 export const wasmvm_sys_cancel_invocation: (a: number, b: number, c: number) => [number, number];
 export const wasmvm_sys_write_output_success: (a: number, b: number, c: number) => [number, number];
 export const wasmvm_sys_write_output_failure: (a: number, b: any) => [number, number];
 export const wasmvm_sys_end: (a: number) => [number, number];
 export const wasmvm_is_processing: (a: number) => number;
+export const wasmvm_last_command_index: (a: number) => number;
 export const __wbg_wasmidentityverifier_free: (a: number, b: number) => void;
 export const wasmidentityverifier_new: (a: number, b: number) => [number, number, number];
 export const wasmidentityverifier_verify_identity: (a: number, b: number, c: number, d: number, e: number) => [number, number];