Fix faulty assertion in AutoForceMergeManagerTests (opensearch-project#19024)

This commit removes a non-deterministic sleep and properly asserts that
the AutoForceMergeManager completes quickly when interrupted. The
previous test logic had a race condition where it checked the interrupt
status of the thread, but that could return false if the thread was in
the process of catching the InterruptException but had not yet reset the
interrupt flag of the thread. The new logic is to set the delay to be
the maximum of 60 seconds and assert that the test thread exits more
quickly than that due to being interrupted.

Signed-off-by: Andrew Ross <[email protected]>

Author: andrross

server/src/test/java/org/opensearch/index/autoforcemerge/AutoForceMergeManagerTests.java

@@ -48,6 +48,7 @@
 import org.junit.Before;
 
 import java.io.IOException;
+import java.time.Duration;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
@@ -531,15 +532,20 @@ public void testForceMergeOperationOnDataNodeWithThreadInterruption() throws Int
         when(indicesService.spliterator()).thenReturn(indexServices.spliterator());
 
         AutoForceMergeManager autoForceMergeManager = clusterSetupWithNode(
-            getConfiguredClusterSettings(true, true, Collections.emptyMap()),
+            getConfiguredClusterSettings(
+                true,
+                true,
+                // Configure maximum delay because this test will interrupt it
+                Map.of(ForceMergeManagerSettings.MERGE_DELAY_BETWEEN_SHARDS_FOR_AUTO_FORCE_MERGE.getKey(), TimeValue.timeValueSeconds(60))
+            ),
             dataNode1
         );
         autoForceMergeManager.start();
         Thread testThread = new Thread(() -> autoForceMergeManager.getTask().runInternal());
         testThread.start();
-        Thread.sleep(1000L);
         testThread.interrupt();
-        assertTrue(testThread.isInterrupted());
+        assertTrue("Expected testThread to exit quickly after being interrupted", testThread.join(Duration.ofSeconds(10)));
+        assertTrue("Expected the interrupt status to be set", testThread.isInterrupted());
         autoForceMergeManager.close();
         executorService.shutdown();
     }