Skip to content

Commit 5962128

Browse files
authored
[GRPC] Bump org.opensearch:protobufs to 0.18.0 and fix compilation errors (opensearch-project#19447)
* upgrade to protobufs 0.18.0 Signed-off-by: Karen X <[email protected]> * add tests Signed-off-by: Karen X <[email protected]> --------- Signed-off-by: Karen X <[email protected]>
1 parent 01425df commit 5962128

24 files changed

+262
-357
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
4949
- Add failureaccess as runtime dependency to transport-grpc module ([#19339](https://github.com/opensearch-project/OpenSearch/pull/19339))
5050
- Migrate usages of deprecated `Operations#union` from Lucene ([#19397](https://github.com/opensearch-project/OpenSearch/pull/19397))
5151
- Delegate primitive write methods with ByteSizeCachingDirectory wrapped IndexOutput ([#19432](https://github.com/opensearch-project/OpenSearch/pull/19432))
52+
- Bump opensearch-protobufs dependency to 0.18.0 and update transport-grpc module compatibility ([#19447](https://github.com/opensearch-project/OpenSearch/issues/19447))
5253

5354
### Fixed
5455
- Fix unnecessary refreshes on update preparation failures ([#15261](https://github.com/opensearch-project/OpenSearch/issues/15261))

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ kotlin = "1.7.10"
2222
antlr4 = "4.13.1"
2323
guava = "33.2.1-jre"
2424
gson = "2.13.2"
25-
opensearchprotobufs = "0.13.0"
25+
opensearchprotobufs = "0.18.0"
2626
protobuf = "3.25.8"
2727
jakarta_annotation = "1.3.5"
2828
google_http_client = "1.44.1"

modules/transport-grpc/licenses/protobufs-0.13.0.jar.sha1

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
e8dc93c60df892184d7c2010e1bd4f15a777c292

modules/transport-grpc/spi/licenses/protobufs-0.13.0.jar.sha1

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
e8dc93c60df892184d7c2010e1bd4f15a777c292

modules/transport-grpc/spi/src/test/java/org/opensearch/transport/grpc/spi/QueryBuilderProtoConverterTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,7 @@ private QueryContainer createMockTermQueryContainer() {
9999
* Helper method to create a mock range query container
100100
*/
101101
private QueryContainer createMockRangeQueryContainer() {
102-
return QueryContainer.newBuilder()
103-
.setRange(org.opensearch.protobufs.RangeQuery.newBuilder().setField("range_field").build())
104-
.build();
102+
return QueryContainer.newBuilder().setRange(org.opensearch.protobufs.RangeQuery.newBuilder().build()).build();
105103
}
106104

107105
/**

modules/transport-grpc/src/main/java/org/opensearch/transport/grpc/proto/request/common/FetchSourceContextProtoUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public static FetchSourceContext parseFromProtoRequest(org.opensearch.protobufs.
4545
// Set up source context if source parameters are provided
4646
if (request.hasXSource()) {
4747
switch (request.getXSource().getSourceConfigParamCase()) {
48-
case BOOL_VALUE:
49-
fetchSource = request.getXSource().getBoolValue();
48+
case BOOL:
49+
fetchSource = request.getXSource().getBool();
5050
break;
5151
case STRING_ARRAY:
5252
sourceIncludes = request.getXSource().getStringArray().getStringArrayList().toArray(new String[0]);
@@ -84,8 +84,8 @@ public static FetchSourceContext parseFromProtoRequest(org.opensearch.protobufs.
8484
if (request.hasXSource()) {
8585
SourceConfigParam source = request.getXSource();
8686

87-
if (source.hasBoolValue()) {
88-
fetchSource = source.getBoolValue();
87+
if (source.hasBool()) {
88+
fetchSource = source.getBool();
8989
} else {
9090
sourceIncludes = source.getStringArray().getStringArrayList().toArray(new String[0]);
9191
}

modules/transport-grpc/src/main/java/org/opensearch/transport/grpc/proto/request/document/bulk/ActiveShardCountProtoUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ public static ActiveShardCount parseProto(WaitForActiveShards waitForActiveShard
4747
default:
4848
return ActiveShardCount.DEFAULT;
4949
}
50-
case INT32_VALUE:
51-
return ActiveShardCount.from(waitForActiveShards.getInt32Value());
50+
case INT32:
51+
return ActiveShardCount.from(waitForActiveShards.getInt32());
5252
case WAITFORACTIVESHARDS_NOT_SET:
5353
default:
5454
return ActiveShardCount.DEFAULT;

modules/transport-grpc/src/main/java/org/opensearch/transport/grpc/proto/request/search/CollapseBuilderProtoUtils.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,12 @@
88
package org.opensearch.transport.grpc.proto.request.search;
99

1010
import org.opensearch.core.xcontent.XContentParser;
11+
import org.opensearch.index.query.InnerHitBuilder;
1112
import org.opensearch.protobufs.FieldCollapse;
1213
import org.opensearch.search.collapse.CollapseBuilder;
1314

1415
import java.io.IOException;
16+
import java.util.List;
1517

1618
/**
1719
* Utility class for converting CollapseBuilder Protocol Buffers to OpenSearch objects.
@@ -43,7 +45,8 @@ protected static CollapseBuilder fromProto(FieldCollapse collapseProto) throws I
4345
collapseBuilder.setMaxConcurrentGroupRequests(collapseProto.getMaxConcurrentGroupSearches());
4446
}
4547
if (collapseProto.getInnerHitsCount() > 0) {
46-
collapseBuilder.setInnerHits(InnerHitsBuilderProtoUtils.fromProto(collapseProto.getInnerHitsList()));
48+
List<InnerHitBuilder> innerHitBuilders = InnerHitsBuilderProtoUtils.fromProto(collapseProto.getInnerHitsList());
49+
collapseBuilder.setInnerHits(innerHitBuilders);
4750
}
4851

4952
return collapseBuilder;

0 commit comments

Comments
 (0)