Skip to content

Commit a6b6ded

Browse files
authored
Enable backward compatibility tests on Mac (opensearch-project#18983)
* Remove banner about bwc tests being disabled on mac Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG and fix existing typo Signed-off-by: Craig Perkins <[email protected]> * Update CHANGELOG entry Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
1 parent 13e2f2d commit a6b6ded

File tree

2 files changed

+2
-19
lines changed

2 files changed

+2
-19
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
2828
### Deprecated
2929

3030
### Removed
31+
- Enable backward compatibility tests on Mac ([#18983](https://github.com/opensearch-project/OpenSearch/pull/18983))
3132

3233
### Fixed
3334
- Fix flaky tests in CloseIndexIT by addressing cluster state synchronization issues ([#18878](https://github.com/opensearch-project/OpenSearch/issues/18878))

build.gradle

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -232,26 +232,8 @@ tasks.register("verifyVersions") {
232232

233233
boolean bwc_tests_enabled = true
234234

235-
/* place an issue link here when committing bwc changes */
236-
String bwc_tests_disabled_issue = ""
237-
238-
/* there's no existing MacOS release, therefore disable bcw tests */
239-
if (Os.isFamily(Os.FAMILY_MAC)) {
240-
bwc_tests_enabled = false
241-
bwc_tests_disabled_issue = "https://github.com/opensearch-project/OpenSearch/issues/4173"
242-
}
243-
244-
if (bwc_tests_enabled == false) {
245-
if (bwc_tests_disabled_issue.isEmpty()) {
246-
throw new GradleException("bwc_tests_disabled_issue must be set when bwc_tests_enabled == false")
247-
}
248-
println "========================= WARNING ========================="
249-
println " Backwards compatibility tests are disabled!"
250-
println "See ${bwc_tests_disabled_issue}"
251-
println "==========================================================="
252-
}
253235
if (project.gradle.startParameter.taskNames.find { it.startsWith("checkPart") } != null) {
254-
// Disable BWC tests for checkPart* tasks as it's expected that this will run un it's own check
236+
// Disable BWC tests for checkPart* tasks as it's expected that this will run in it's own check
255237
bwc_tests_enabled = false
256238
}
257239

0 commit comments

Comments
 (0)