Skip to content

Commit 22071cb

Browse files
authored
Merge pull request #106 from Neur0toxine/update-phoneiso
update iso3166 prefixes
2 parents 45fa7a7 + 4958eaa commit 22071cb

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

core/util/phone.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import (
88
"strconv"
99
"strings"
1010

11+
phoneiso3166 "github.com/Neur0toxine/go-phone-iso3166"
1112
pn "github.com/nyaruka/phonenumbers"
12-
phoneiso3166 "github.com/onlinecity/go-phone-iso3166"
1313
)
1414

1515
const (
@@ -32,7 +32,7 @@ var (
3232
ErrCannotParsePhone = errors.New("cannot parse phone number")
3333

3434
TrimmedPhoneRegexp = regexp.MustCompile(`\D+`)
35-
UndefinedUSCodes = []string{"1943", "1445", "1945", "1840", "1448", "1279", "1839", "1555", "1771", "1645"}
35+
UndefinedUSCodes = []string{"1555"}
3636
)
3737

3838
// FormatNumberForWA forms in the format according to the rules https://faq.whatsapp.com/1294841057948784

core/util/phone_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func TestParsePhone(t *testing.T) {
4848
})
4949

5050
t.Run("us numbers", func(t *testing.T) {
51-
for _, usMask := range UndefinedUSCodes {
51+
for _, usMask := range []string{"1943", "1445", "1945", "1840", "1448", "1279", "1839", "1555", "1771", "1645", "1640"} {
5252
t.Run(fmt.Sprintf("mask %s", usMask), func(t *testing.T) {
5353
pNumber := usMask + "7043340"
5454
pPhone, err := ParsePhone(pNumber)

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ toolchain go1.23.4
66

77
require (
88
github.com/DATA-DOG/go-sqlmock v1.5.2
9+
github.com/Neur0toxine/go-phone-iso3166 v0.0.3
910
github.com/aws/aws-sdk-go v1.36.30
1011
github.com/aws/aws-sdk-go-v2 v1.18.0
1112
github.com/aws/aws-sdk-go-v2/config v1.18.22
@@ -27,7 +28,6 @@ require (
2728
github.com/jinzhu/gorm v1.9.11
2829
github.com/nicksnyder/go-i18n/v2 v2.4.1
2930
github.com/nyaruka/phonenumbers v1.5.0
30-
github.com/onlinecity/go-phone-iso3166 v0.0.1
3131
github.com/retailcrm/api-client-go/v2 v2.1.17
3232
github.com/retailcrm/mg-transport-api-client-go v1.3.23
3333
github.com/retailcrm/zabbix-metrics-collector v1.0.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ github.com/BurntSushi/toml v1.4.0/go.mod h1:ukJfTF/6rtPPRCnwkur4qwRxa8vTRFBF0uk2
3737
github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
3838
github.com/DATA-DOG/go-sqlmock v1.5.2 h1:OcvFkGmslmlZibjAjaHm3L//6LiuBgolP7OputlJIzU=
3939
github.com/DATA-DOG/go-sqlmock v1.5.2/go.mod h1:88MAG/4G7SMwSE3CeA0ZKzrT5CiOU3OJ+JlNzwDqpNU=
40+
github.com/Neur0toxine/go-phone-iso3166 v0.0.3 h1:8zXDumas8c/hUD8TQ7YFv3ZnYTr8rd3Ap2mKJixUOIQ=
41+
github.com/Neur0toxine/go-phone-iso3166 v0.0.3/go.mod h1:KT+RhWWrAeHk/FbMHxMsh7eX0V5XaG27bsEuzWtugqk=
4042
github.com/Shopify/sarama v1.19.0/go.mod h1:FVkBWblsNy7DGZRfXLU0O9RCGt5g3g3yEuWXgklEdEo=
4143
github.com/Shopify/toxiproxy v2.1.4+incompatible/go.mod h1:OXgGpZ6Cli1/URJOF1DMxUHB2q5Ap20/P/eIdh4G0pI=
4244
github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
@@ -289,8 +291,6 @@ github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWb
289291
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno=
290292
github.com/nyaruka/phonenumbers v1.5.0 h1:0M+Gd9zl53QC4Nl5z1Yj1O/zPk2XXBUwR/vlzdXSJv4=
291293
github.com/nyaruka/phonenumbers v1.5.0/go.mod h1:gv+CtldaFz+G3vHHnasBSirAi3O2XLqZzVWz4V1pl2E=
292-
github.com/onlinecity/go-phone-iso3166 v0.0.1 h1:srN6o8NjxBWIrlK6Z+zD9wGMSGYi4itWA/fRyaxetqs=
293-
github.com/onlinecity/go-phone-iso3166 v0.0.1/go.mod h1:n8+yIOCu9O63MH3WVwlWq1YVF6ZuAG5xlZ4mZ5ZzKF8=
294294
github.com/onsi/ginkgo v1.6.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE=
295295
github.com/onsi/ginkgo v1.7.0/go.mod h1:lLunBs/Ym6LB5Z9jYTR76FiuTmxDTDusOGeTQH+WWjE=
296296
github.com/onsi/gomega v1.4.3/go.mod h1:ex+gbHU/CVuBBDIJjb2X0qEXbFg53c61hWP/1CpauHY=

0 commit comments

Comments
 (0)