Merge branch 'feature/log_connection_errors' into develop

Author: dancannon

CHANGELOG.md

@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
+### Changed
+- Improved logging of connection errors
+
 ### Fixed
 - Fixed bug causing empty times to be inserted into the DB even when the omitempty tag was set.
 

cluster.go

@@ -191,6 +191,7 @@ func (c *Cluster) connectNodes(hosts []Host) {
 	for _, host := range hosts {
 		conn, err := NewConnection(host.String(), c.opts)
 		if err != nil {
+			log.Warnf("Error creating connection %s", err.Error())
 			continue
 		}
 		defer conn.Close()
@@ -201,6 +202,7 @@ func (c *Cluster) connectNodes(hosts []Host) {
 			c.opts,
 		))
 		if err != nil {
+			log.Warnf("Error fetching cluster status %s", err)
 			continue
 		}
 

connection_helper.go

@@ -5,6 +5,7 @@ import (
 	"encoding/binary"
 	"fmt"
 	"io"
+	"strings"
 
 	p "github.com/dancannon/gorethink/ql2"
 )
@@ -60,6 +61,7 @@ func (c *Connection) readHandshakeSuccess() error {
 	// convert to string and remove trailing NUL byte
 	response := string(line[:len(line)-1])
 	if response != "SUCCESS" {
+		response = strings.TrimSpace(response)
 		// we failed authorization or something else terrible happened
 		return RqlDriverError{fmt.Sprintf("Server dropped connection with message: \"%s\"", response)}
 	}