Make it easier for new contributors to regenerate the test suite (#495)

"make generate" will now regenerate the ReQL test code.  If the path
to the Rethink working directory isn't set, it will now give the
developer more explanation what to do.

Co-authored-by: Cody Jones <[email protected]>

Author: CodyDWJones

.gitignore

@@ -10,6 +10,7 @@
 # Folders
 _obj
 _test
+__pycache__
 
 # Architecture specific extensions/prefixes
 *.[568vq]

Makefile

@@ -8,3 +8,7 @@ integration:
 
 benchpool:
 	go test -v -cpu 1,2,4,8,16,24,32,64,128,256 -bench=BenchmarkConnectionPool -run ^$ ./internal/integration/tests/
+
+generate:
+	go generate ./internal/...
+

internal/gen_tests/gen_tests.sh

@@ -2,13 +2,15 @@
 
 set -e
 
-if [[ $REQL_TEST_DIR == "" ]]
+if [[ ! -d $REQL_TEST_DIR ]]
 then
-    echo "\$REQL_TEST_DIR must be specified"
+    echo "REQL_TEST_DIR must be set to the local copy of the https://github.com/rethinkdb/rethinkdb/tree/next/test/rql_test/src/ directory."
     exit 1
 fi
 
-../gen_tests/gen_tests.py --test-dir=$REQL_TEST_DIR
+SCRIPT_DIR=$(dirname "$0")
+
+$SCRIPT_DIR/gen_tests.py --test-dir=$REQL_TEST_DIR
 
 goimports -w . > /dev/null
 

internal/integration/reql_tests/gorethink_test.go

@@ -1,4 +1,4 @@
-//go:generate ../gen_tests/gen_tests.sh
+//go:generate ../../gen_tests/gen_tests.sh
 
 package reql_tests