fix default context timeout if one of config's timeout is omitted

Aleksander Mogilko · Aleksander Mogilko · commit a5695d4a5584 · 2017-09-04T17:36:55.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,11 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
-## v3.0.3 - 2071-09-03
+## v3.0.4 - 2017-09-04
+
+- Fixed default context timeout if one of config's timeout os omitted
+
+## v3.0.3 - 2017-09-03
 
 - Added support to cancellation queries and timeouts with `context.Context` passed through `RunOpts`
 - Fixed import path for `sirupsen/logrus` due to repo was renamed
diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@
 
 ![GoRethink Logo](https://raw.github.com/wiki/gorethink/gorethink/gopher-and-thinker-s.png "Golang Gopher and RethinkDB Thinker")
 
-Current version: v3.0.3 (RethinkDB v2.3)
+Current version: v3.0.4 (RethinkDB v2.3)
 
 <!-- This project is no longer maintained, for more information see the [v3.0.0 release](https://github.com/gorethink/gorethink/releases/tag/v3.0.0)-->
 
diff --git a/connection_helper.go b/connection_helper.go
@@ -45,7 +45,7 @@ func (c *Connection) writeQuery(token int64, q []byte) error {
 
 func (c *Connection) contextFromConnectionOpts() context.Context {
 	sum := c.opts.ReadTimeout + c.opts.WriteTimeout
-	if sum == 0 {
+	if c.opts.ReadTimeout == 0 || c.opts.WriteTimeout == 0 {
 		return context.Background()
 	}
 	ctx, _ := context.WithTimeout(context.Background(), sum)

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func (c *Connection) writeQuery(token int64, q []byte) error {`
`45`	`45`
`46`	`46`	`func (c *Connection) contextFromConnectionOpts() context.Context {`
`47`	`47`	`sum := c.opts.ReadTimeout + c.opts.WriteTimeout`
`48`		`- if sum == 0 {`
	`48`	`+ if c.opts.ReadTimeout == 0 \|\| c.opts.WriteTimeout == 0 {`
`49`	`49`	`return context.Background()`
`50`	`50`	`}`
`51`	`51`	`ctx, _ := context.WithTimeout(context.Background(), sum)`