Add get_gains_string() method to openbci_gain_tracker and remove hardcoded limits

Author: retiutut

src/board_controller/openbci/galea.cpp

@@ -117,17 +117,7 @@ int Galea::config_board (std::string conf, std::string &response)
 
     if (conf == "get_gains")
     {
-        std::stringstream gains;
-
-        for (int i = 0; i < 20; i++)
-        {
-            gains << gain_tracker.get_gain_for_channel (i);
-            if (i < 19)
-            {
-                gains << ", ";
-            }
-        }
-        response = gains.str ();
+        response = gain_tracker.get_gains_string ();
         safe_logger (spdlog::level::info, "gains for all channels: {}", response);
         return (int)BrainFlowExitCodes::STATUS_OK;
     }

src/board_controller/openbci/inc/openbci_gain_tracker.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <algorithm>
+#include <sstream>
 #include <stdlib.h>
 #include <string>
 #include <vector>
@@ -126,6 +127,20 @@ class OpenBCIGainTracker
     {
         std::copy (old_gains.begin (), old_gains.end (), current_gains.begin ());
     }
+
+    virtual std::string get_gains_string ()
+    {
+        std::stringstream gains;
+        for (size_t i = 0; i < current_gains.size (); i++)
+        {
+            gains << current_gains[i];
+            if (i < current_gains.size () - 1)
+            {
+                gains << ", ";
+            }
+        }
+        return gains.str ();
+    }
 };
 
 class CytonGainTracker : public OpenBCIGainTracker