Fix game launching and theme unloading

Author: rsubtil

scenes/game_launched/GameLaunched.gd

@@ -48,11 +48,10 @@ func _input(event):
 	if event.is_action_pressed("rh_menu"):
 		n_timer.start()
 
-func set_info(logo_path: String, game_name: String, emu_name: String):
-	n_emu_logo.texture = load(logo_path)
-	n_game_name.text = game_name_orig_text % game_name
-	n_emu_name.text = emu_name_orig_text % emu_name
-
+func _ready():
+	n_emu_logo.texture = load("res://assets/emulators/%s.png" % RetroHub.launched_emulator["name"])
+	n_game_name.text = game_name_orig_text % RetroHub.launched_game_data.name
+	n_emu_name.text = emu_name_orig_text % RetroHub.launched_emulator["fullname"]
 
 func _on_Timer_timeout():
 	RetroHub.kill_game_process()

scenes/popups/scraper/StopScraperDialog.gd

@@ -4,13 +4,5 @@ extends ConfirmationDialog
 
 @onready var base_text : String = n_stop_description.text
 
-func _ready():
-	# The size is reset by the parent popup, so this prevents this one
-	# from getting the same size as parent, covering the whole screen
-
-	# FIXME: Since Popup is no longer a Control this might not be necessary anymore. Confirm
-	#size = custom_minimum_size
-	pass
-
 func set_num_games_pending(num_games_pending: int):
 	n_stop_description.text = base_text % num_games_pending

scenes/root/Root.gd

@@ -115,11 +115,8 @@ func _on_theme_unload():
 
 func _on_game_loaded(game_data: RetroHubGameData):
 	var game_launched_child : PackedScene = load("res://scenes/game_launched/GameLaunched.tscn")
+	n_viewport.clear_theme()
 	n_viewport.set_theme(game_launched_child)
-	game_launched_child.set_info(
-		"res://assets/emulators/%s.png" % RetroHub.launched_emulator["name"],
-		game_data.name,
-		RetroHub.launched_emulator["fullname"])
 	print("Loaded game")
 
 func set_theme_input_enabled(enabled : bool):

scenes/root/Viewport.gd

@@ -9,11 +9,6 @@ func set_theme(scene: PackedScene):
 
 func clear_theme():
 	remove_child(n_theme_node)
-	n_theme_node.set_process(false)
-	n_theme_node.set_process_input(false)
-	n_theme_node.set_process_unhandled_input(false)
-	n_theme_node.set_process_unhandled_key_input(false)
-	n_theme_node.set_physics_process(false)
-	n_theme_node.free()
+	n_theme_node.queue_free()
 	#while is_instance_valid(n_theme_node):
 	#	await get_tree().process_frame