Skip to content

Commit fb6ae40

Browse files
committed
Fix incorrect logic for ensuring new line at eof
1 parent 824f68c commit fb6ae40

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

repo_gen/generate_repo.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -431,16 +431,18 @@ def generate_build_files(dir, actions):
431431
os.makedirs(f"{dir}/{name}", exist_ok=True)
432432

433433
with open(f"{dir}/{name}/BUILD", 'w') as file:
434-
file.write(build_tpl.format(name = name))
435-
file.write(create_link_args(config))
436-
file.write(create_version_aliases(config, dir, actions))
437-
file.write(create_top_level_config_settings_group(config))
438-
file.write(create_version_configs(config))
439-
file.write(create_latest(config, dir))
440-
file.write(create_latest_with_configurations(config, dir))
441-
file.write(create_version(config))
442-
# strip the last one to ensure the output only has a single newline at the end
443-
file.write(create_version_with_configurations(config, dir).strip())
434+
build = build_tpl.format(name = name)
435+
build += create_link_args(config)
436+
build += create_version_aliases(config, dir, actions)
437+
build += create_top_level_config_settings_group(config)
438+
build += create_version_configs(config)
439+
build += create_latest(config, dir)
440+
build += create_latest_with_configurations(config, dir)
441+
build += create_version(config)
442+
build += create_version_with_configurations(config, dir)
443+
444+
# ensure a single newline at the end of the file
445+
file.write(build.strip())
444446
file.write("\n")
445447

446448
for config in configs:

0 commit comments

Comments
 (0)