Skip to content

Implement NewVersionAvailable component #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: phase-1
Choose a base branch
from
Open

Implement NewVersionAvailable component #11

wants to merge 2 commits into from

Conversation

@AllenFang
Copy link
Member

@AllenFang AllenFang commented Jul 18, 2017

self explanatory, please review @CYBAI

AllenFang added 2 commits July 18, 2017 23:15
@AllenFang
implement NewVersionAvailable component
151fc5a
@AllenFang
1. add test case for NewVersionAvailable component
985cfe3 
2. also patch reudcer test for DISMISS_GIT_VERSION_ERROR and DISMISS_NEW_VERSION actions
@AllenFang AllenFang added this to the 0.1.0-alpha.1 milestone Jul 18, 2017
CYBAI
CYBAI approved these changes Jul 23, 2017
View reviewed changes
Copy link
Contributor

@CYBAI CYBAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CYBAI CYBAI CYBAI approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.1.0-alpha.1

Development

Successfully merging this pull request may close these issues.

2 participants

@AllenFang @CYBAI