Skip to content

Commit b606ec9

Browse files
authored
Merge pull request #138 from notzippy/develop
Re added the requirement for the -a, without this the flags would not…
2 parents cfe5bf4 + 01ccd69 commit b606ec9

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

harness/build.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@ func Build(c *model.CommandConfig, paths *model.RevelContainer) (app *App, compi
243243
utils.Logger.Info("Exec:", "args", getCmd.Args)
244244
getOutput, err := getCmd.CombinedOutput()
245245
if err != nil {
246-
utils.Logger.Error("Build failed", "message", stOutput)
246+
utils.Logger.Error("Build failed", "message", stOutput, "error", err)
247247
utils.Logger.Error("Failed to fetch the output", "getOutput", string(getOutput))
248248
return nil, newCompileError(paths, output)
249249
}

model/command_config.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,31 +47,31 @@ type (
4747
// The build command
4848
Build struct {
4949
TargetPath string `short:"t" long:"target-path" description:"Path to target folder. Folder will be completely deleted if it exists" required:"true"`
50-
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" `
50+
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" required:"true"`
5151
Mode string `short:"m" long:"run-mode" description:"The mode to run the application in"`
5252
CopySource bool `short:"s" long:"include-source" description:"Copy the source code as well"`
5353
} `command:"build"`
5454
// The run command
5555
Run struct {
56-
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" `
56+
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" required:"true"`
5757
Mode string `short:"m" long:"run-mode" description:"The mode to run the application in"`
5858
Port string `short:"p" long:"port" description:"The port to listen"`
5959
NoProxy bool `short:"n" long:"no-proxy" description:"True if proxy server should not be started. This will only update the main and routes files on change"`
6060
} `command:"run"`
6161
// The package command
6262
Package struct {
6363
Mode string `short:"m" long:"run-mode" description:"The mode to run the application in"`
64-
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" `
64+
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" required:"true"`
6565
CopySource bool `short:"s" long:"include-source" description:"Copy the source code as well"`
6666
} `command:"package"`
6767
// The clean command
6868
Clean struct {
69-
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" `
69+
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" required:"true"`
7070
} `command:"clean"`
7171
// The test command
7272
Test struct {
7373
Mode string `short:"m" long:"run-mode" description:"The mode to run the application in"`
74-
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" `
74+
ImportPath string `short:"a" long:"application-path" description:"Path to applicaiton folder" required:"true"`
7575
Function string `short:"f" long:"suite-function" description:"The suite.function"`
7676
} `command:"test"`
7777
// The version command
@@ -133,6 +133,6 @@ func (c *CommandConfig) UpdateImportPath() bool {
133133
}
134134

135135
c.ImportPath = importPath
136-
utils.Logger.Info("Returned import path", "path", importPath)
136+
utils.Logger.Info("Returned import path", "path", importPath, "buildpath",build.Default.GOPATH)
137137
return (len(importPath) > 0 || !required)
138138
}

0 commit comments

Comments
 (0)