Skip to content

Commit b366767

Browse files
Sniper91Sniper91
authored
removed deprecated label url of rest_client_request_duration_seconds_bucket (kubernetes-monitoring#1007)
Signed-off-by: Sniper91 <[email protected]>
1 parent 03c13f9 commit b366767

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

‎dashboards/controller-manager.libsonnet‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,19 +151,19 @@ local var = g.dashboard.variable;
151151
+ tsPanel.queryOptions.withTargets([
152152
prometheus.new(
153153
'${datasource}',
154-
'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeControllerManagerSelector)s, instance=~"$instance", verb="POST"}[%(grafanaIntervalVar)s])) by (verb, url, le))' % $._config
154+
'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeControllerManagerSelector)s, instance=~"$instance", verb="POST"}[%(grafanaIntervalVar)s])) by (verb, le))' % $._config
155155
)
156-
+ prometheus.withLegendFormat('{{verb}} {{url}}'),
156+
+ prometheus.withLegendFormat('{{verb}}'),
157157
]),
158158

159159
tsPanel.new('Get Request Latency 99th Quantile')
160160
+ tsPanel.standardOptions.withUnit('s')
161161
+ tsPanel.queryOptions.withTargets([
162162
prometheus.new(
163163
'${datasource}',
164-
'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeControllerManagerSelector)s, instance=~"$instance", verb="GET"}[%(grafanaIntervalVar)s])) by (verb, url, le))' % $._config
164+
'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeControllerManagerSelector)s, instance=~"$instance", verb="GET"}[%(grafanaIntervalVar)s])) by (verb, le))' % $._config
165165
)
166-
+ prometheus.withLegendFormat('{{verb}} {{url}}'),
166+
+ prometheus.withLegendFormat('{{verb}}'),
167167
]),
168168

169169
tsPanel.new('Memory')

‎dashboards/kubelet.libsonnet‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ local var = g.dashboard.variable;
206206
tsPanel.new('Request duration 99th quantile')
207207
+ tsPanel.standardOptions.withUnit('s')
208208
+ tsPanel.queryOptions.withTargets([
209-
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster",%(kubeletSelector)s, instance=~"$instance"}[%(grafanaIntervalVar)s])) by (instance, verb, url, le))' % $._config)
210-
+ prometheus.withLegendFormat('{{instance}} {{verb}} {{url}}'),
209+
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster",%(kubeletSelector)s, instance=~"$instance"}[%(grafanaIntervalVar)s])) by (instance, verb, le))' % $._config)
210+
+ prometheus.withLegendFormat('{{instance}} {{verb}}'),
211211
]),
212212
tsMemory:
213213
tsPanel.new('Memory')

‎dashboards/proxy.libsonnet‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,16 +132,16 @@ local var = g.dashboard.variable;
132132
+ tsPanel.gridPos.withW(16)
133133
+ tsPanel.standardOptions.withUnit('ops')
134134
+ tsPanel.queryOptions.withTargets([
135-
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeProxySelector)s,instance=~"$instance",verb="POST"}[%(grafanaIntervalVar)s])) by (verb, url, le))' % $._config)
136-
+ prometheus.withLegendFormat('{{verb}} {{url}}'),
135+
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeProxySelector)s,instance=~"$instance",verb="POST"}[%(grafanaIntervalVar)s])) by (verb, le))' % $._config)
136+
+ prometheus.withLegendFormat('{{verb}}'),
137137
]),
138138

139139
tsPanel.new('Get Request Latency 99th Quantile')
140140
+ tsPanel.gridPos.withW(24)
141141
+ tsPanel.standardOptions.withUnit('s')
142142
+ tsPanel.queryOptions.withTargets([
143-
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeProxySelector)s, instance=~"$instance", verb="GET"}[%(grafanaIntervalVar)s])) by (verb, url, le))' % $._config)
144-
+ prometheus.withLegendFormat('{{verb}} {{url}}'),
143+
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeProxySelector)s, instance=~"$instance", verb="GET"}[%(grafanaIntervalVar)s])) by (verb, le))' % $._config)
144+
+ prometheus.withLegendFormat('{{verb}}'),
145145
]),
146146

147147

‎dashboards/scheduler.libsonnet‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,16 @@ local var = g.dashboard.variable;
137137
+ tsPanel.gridPos.withW(16)
138138
+ tsPanel.standardOptions.withUnit('ops')
139139
+ tsPanel.queryOptions.withTargets([
140-
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeSchedulerSelector)s, instance=~"$instance", verb="POST"}[%(grafanaIntervalVar)s])) by (verb, url, le))' % $._config)
141-
+ prometheus.withLegendFormat('{{verb}} {{url}}'),
140+
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeSchedulerSelector)s, instance=~"$instance", verb="POST"}[%(grafanaIntervalVar)s])) by (verb, le))' % $._config)
141+
+ prometheus.withLegendFormat('{{verb}}'),
142142
]),
143143

144144
tsPanel.new('Get Request Latency 99th Quantile')
145145
+ tsPanel.gridPos.withW(24)
146146
+ tsPanel.standardOptions.withUnit('s')
147147
+ tsPanel.queryOptions.withTargets([
148-
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeSchedulerSelector)s, instance=~"$instance", verb="GET"}[%(grafanaIntervalVar)s])) by (verb, url, le))' % $._config)
149-
+ prometheus.withLegendFormat('{{verb}} {{url}}'),
148+
prometheus.new('${datasource}', 'histogram_quantile(0.99, sum(rate(rest_client_request_duration_seconds_bucket{%(clusterLabel)s="$cluster", %(kubeSchedulerSelector)s, instance=~"$instance", verb="GET"}[%(grafanaIntervalVar)s])) by (verb, le))' % $._config)
149+
+ prometheus.withLegendFormat('{{verb}}'),
150150
]),
151151

152152

0 commit comments

Comments
 (0)