fixed/type-undefined auto-commit (#379) (#380)

Co-authored-by: Matias <49443249+ahumadamatias@users.noreply.github.com>

Author: NicoGarcia12

CHANGELOG.md

@@ -6,10 +6,20 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+## [2.6.1] - 2026-01-13
+
+-   Sync code with 2.5.1
+
 ## [2.6.0] - 2025-09-24
 
 -   Migrate to angular 19
 
+## [2.5.1] - 2025-12-10
+
+### Fixed
+
+- Fixed service undefined ([#379](https://github.com/reyesoft/ngx-jsonapi/pull/379))
+
 ## [2.5.0] - 2025-09-16
 
 -   Migrate to angular 18

package.json

@@ -178,6 +178,7 @@
     "ts-node": "3.1.0",
     "typescript": "5.8.2",
     "uglify-js": "3.1.9",
+    "to-fast-properties": "^2.0.0",
     "zone.js": "0.15.1"
   },
   "dependencies": {
@@ -187,5 +188,5 @@
     "tsickle": "0.39.1",
     "tslib": "^2.6.0"
   },
-  "version": "2.6.0"
-}
+  "version": "2.6.1"
+}

projects/ngx-jsonapi-lib/package.json

@@ -1,6 +1,6 @@
 {
     "name": "ngx-jsonapi",
-    "version": "2.6.0",
+    "version": "2.6.1",
     "description": "JSON API library for Angular",
     "module": "ngx-jsonapi/@ngx-jsonapi/ngx-jsonapi.es5.js",
     "es2015": "ngx-jsonapi/@ngx-jsonapi/ngx-jsonapi.js",

projects/ngx-jsonapi-lib/src/lib/resource.spec.ts

@@ -10,6 +10,18 @@ import { of } from 'rxjs';
 import { Book } from './tests/factories/books.service';
 import { Service } from './service';
 
+// Inicializar Core.me antes de los tests
+beforeAll(() => {
+    if (!Core.me) {
+        Core.me = {
+            getResourceService: jest.fn().mockReturnValue(undefined),
+            getResourceServiceOrFail: jest.fn(),
+            registerService: jest.fn(),
+            resourceServices: {}
+        } as any;
+    }
+});
+
 describe('resource', () => {
     // it('should be reset()', () => {
     //     resource.id = 'some-id';
@@ -133,6 +145,13 @@ describe('resource.toObject() method', () => {
             }
         };
         jest.spyOn(Resource.prototype, 'getService').mockReturnValue(mocked_service_data as Service<Resource>);
+        // Configurar Core.me.getResourceService para retornar el servicio mock cuando se busque el tipo 'main'
+        jest.spyOn(Core.me, 'getResourceService').mockImplementation((type: string) => {
+            if (type === 'main') {
+                return mocked_service_data as Service<Resource>;
+            }
+            return undefined;
+        });
         let new_resource: Resource = new Resource();
         new_resource.type = 'main';
         new_resource.id = '1';

projects/ngx-jsonapi-lib/src/lib/resource.ts

@@ -132,9 +132,10 @@ export class Resource implements ICacheable {
 
         // just for performance dont copy if not necessary
         let attributes: any;
-        if (this.getService() && this.getService().parseToServer) {
+        let service: Service | undefined = this.getServiceOrUndefined();
+        if (service && service.parseToServer) {
             attributes = { ...{}, ...this.attributes };
-            this.getService().parseToServer(attributes);
+            service.parseToServer(attributes);
         } else {
             attributes = this.attributes;
         }
@@ -167,6 +168,7 @@ export class Resource implements ICacheable {
 
     public fill(data_object: IDocumentResource | ICacheableDocumentResource): boolean {
         this.id = data_object.data.id || '';
+        this.type = data_object.data.type || '';
 
         // WARNING: leaving previous line for a tiem because this can produce undesired behavior
         // this.attributes = data_object.data.attributes || this.attributes;
@@ -283,6 +285,13 @@ export class Resource implements ICacheable {
         return Converter.getServiceOrFail(this.type);
     }
 
+    /*
+    @return This resource like a service or undefined if not registered
+    */
+    public getServiceOrUndefined(): Service | undefined {
+        return Converter.getService(this.type);
+    }
+
     public delete(): Observable<void> {
         return this.getService().delete(this.id);
     }

projects/ngx-jsonapi-lib/src/lib/services/json-ripper.spec.ts

@@ -5,6 +5,19 @@ import { TestFactory } from '../tests/factories/test-factory';
 import { IElement } from '../data-providers/data-provider';
 import { ICacheableDocumentResource } from '../interfaces/data-object';
 import { ICacheableDataCollection } from '../interfaces/data-collection';
+import { Core } from '../core';
+
+// Inicializar Core.me antes de los tests
+beforeAll(() => {
+    if (!Core.me) {
+        Core.me = {
+            getResourceService: jest.fn().mockReturnValue(undefined),
+            getResourceServiceOrFail: jest.fn(),
+            registerService: jest.fn(),
+            resourceServices: {}
+        } as any;
+    }
+});
 
 describe('JsonRipper for resources', () => {
     let book: any = TestFactory.getBook('5');

projects/ngx-jsonapi-lib/src/lib/services/resource-relationships-converter.ts

@@ -78,6 +78,7 @@ export class ResourceRelationshipsConverter {
         // TODO: FE-92 --- this.is a hotfix... check and improve conditions when building has-one relationships
         if (!this.relationships_dest[relation_alias].data) {
             this.relationships_dest[relation_alias].data = new Resource();
+            (<Resource>this.relationships_dest[relation_alias].data).type = relation_data_from.data.type;
         }
 
         if (relation_data_from.data.id !== (<Resource>this.relationships_dest[relation_alias].data).id) {