Fe 294 v2.3 ngx jsonapi corregir los errores (#332)

Author: FacuLuna745

.circleci/config.yml

@@ -14,7 +14,7 @@ jobs:
       - run: yarn prettier-ts:show --list-different
       - run: yarn prettier-md:show --list-different
       - run: yarn prettier-scss:show --list-different
-    #   - run: yarn lint Descomentar en la tarea FE-294
+      - run: yarn lint 
       - save_cache:
           key: *cache_key
           paths:

CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+### Fixed
+
+-   Fixed error lint with eslint ([#332](https://github.com/reyesoft/ngx-jsonapi/pull/332))
+
 ### Changed
 
 -   Migrated tslint to eslint. ([#331](https://github.com/reyesoft/ngx-jsonapi/pull/331))

src/cloned-document-resource.ts

@@ -65,6 +65,7 @@ export class ClonedDocumentResource {
         if (!this.resource_object.data.relationships || !this.parent_resource_object.data.relationships) {
             return this;
         }
+        // eslint-disable-next-line no-restricted-syntax
         for (let relationship in this.resource_object.data.relationships) {
             if (
                 isEqual(this.resource_object.data.relationships[relationship], this.parent_resource_object.data.relationships[relationship])
@@ -80,6 +81,7 @@ export class ClonedDocumentResource {
         if (!this.resource_object.data.attributes || !this.parent_resource_object.data.attributes) {
             return this;
         }
+        // eslint-disable-next-line no-restricted-syntax
         for (let attribute in this.resource_object.data.attributes) {
             if (this.resource_object.data.attributes[attribute] === this.parent_resource_object.data.attributes[attribute]) {
                 delete this.resource_object.data.attributes[attribute];

src/document-collection.ts

@@ -51,12 +51,12 @@ export class RelatedDocumentCollection<R extends Resource = Resource> extends Do
         }
 
         // convert and add new dataresoures to final collection
-        let new_ids = {};
+        let new_ids: any = {};
         this.data.length = 0;
         this.builded = data_collection.data && data_collection.data.length === 0;
         for (let dataresource of data_collection.data) {
             try {
-                let res = this.getResourceOrFail(dataresource);
+                let res: Resource = this.getResourceOrFail(dataresource);
                 res.fill({ data: dataresource });
                 new_ids[dataresource.id] = dataresource.id;
                 (<Array<R>>this.data).push(<R>res);

src/document.ts

@@ -20,8 +20,7 @@ interface IDocumentHasResource {
     data: Resource;
     content: 'resource';
 }
-export /* abstract */ class Document
-    implements IDocumentData, IDocumentHasResources, IDocumentHasIds, IDocumentHasId, IDocumentHasResource {
+export class Document implements IDocumentData, IDocumentHasResources, IDocumentHasIds, IDocumentHasId, IDocumentHasResource {
     public data: any;
     public builded: boolean = false;
     public content: any;

src/jsonapi-config.ts

@@ -3,7 +3,7 @@ export class JsonapiConfig {
     public params_separator?: string = '?';
     public unify_concurrency?: boolean = true;
     public cache_prerequests?: boolean = true;
-    /* eslint-disable id-blacklist */
+    /* eslint-disable */
     public parameters?:
         | {
               page: {
@@ -17,5 +17,5 @@ export class JsonapiConfig {
             size: 'page[size]'
         }
     };
-    /* eslint-enable id-blacklist */
+    /* eslint-enable */
 }

src/resource.spec.ts

@@ -51,7 +51,7 @@ describe('resource', () => {
         let exec_spy: jasmine.Spy = spyOn(Core, 'exec').and.returnValue(of({ data: response }));
         await resource.save();
         resource.relationships = {};
-        let expected_resource_in_save = {
+        let expected_resource_in_save: any = {
             data: {
                 type: 'tests',
                 id: '1234',
@@ -291,7 +291,7 @@ describe('resource.toObject() method', () => {
         book.removeRelationship('author', '1');
         expect(book.relationships.author.data).toBeNull();
 
-        let book_object = book.toObject();
+        let book_object: IDocumentResource = book.toObject();
         expect(book_object.data.relationships?.author.data).toBeNull();
         expect(book_object.included).toBeFalsy();
     });

src/resource.ts

@@ -360,7 +360,7 @@ export class Resource implements ICacheable {
         });
     }
 
-    public setCacheLastUpdate(value = Date.now()): void {
+    public setCacheLastUpdate(value: number = Date.now()): void {
         this.cache_last_update = value;
     }
 }

src/service.spec.ts

@@ -766,6 +766,7 @@ describe('service.all() and next service.get()', () => {
                 map(emit => {
                     expect(http_request_spy).not.toHaveBeenCalled();
                     expect(emit.relationships.author.data.attributes.name).toBeTruthy();
+
                     return { loaded: emit.loaded, source: emit.source };
                 }),
                 toArray()
@@ -796,8 +797,8 @@ describe('service.all() and next service.get()', () => {
         let book: Book = await booksService.get('1', { include: ['author'] }).toPromise();
         expect(book.id).toBe('1');
         test_response_subject.complete();
-
-        let books_api = TestFactory.getCollectionDocumentData(Book, 1, ['author']);
+        // eslint-disable-next-line
+        let books_api: IDocumentData<Resource> = TestFactory.getCollectionDocumentData(Book, 1, ['author']);
         books_api.data[0].id = '1';
         test_response_subject = new BehaviorSubject(new HttpResponse());
         test_response_subject.next(new HttpResponse({ body: books_api }));
@@ -812,6 +813,7 @@ describe('service.all() and next service.get()', () => {
                     if (emit.loaded) {
                         expect(emit.data[0].relationships.author.data.attributes.name).toBeTruthy();
                     }
+
                     return { loaded: emit.loaded, source: emit.source };
                 }),
                 toArray()
@@ -995,6 +997,7 @@ describe('service.get()', () => {
         let emits: Array<{
             loaded: boolean;
             source: SourceType;
+            // eslint-disable-next-line max-lines
         }> = await booksService
             .get('1', { ttl: 1000, include: ['author'] })
             .pipe(
@@ -1251,7 +1254,7 @@ describe('service.get()', () => {
         test_response_subject.next(new HttpResponse({ body: body_resource }));
 
         book.ttl = 0;
-        let json_ripper = new JsonRipper();
+        let json_ripper: JsonRipper = new JsonRipper();
         json_ripper.saveResource(book);
         let cachememory: CacheMemory = CacheMemory.getInstance();
         cachememory.removeResource('books', '1'); // kill only memory cache

src/service.ts

@@ -266,6 +266,7 @@ export class Service<R extends Resource = Resource> {
         path.applyParams(this, builded_params);
 
         let temporary_collection: DocumentCollection<R> = this.getOrCreateCollection(path);
+        // eslint-disable-next-line id-blacklist
         temporary_collection.page.number = builded_params.page.number * 1;
 
         let subject: BehaviorSubject<DocumentCollection<R>> = new BehaviorSubject<DocumentCollection<R>>(temporary_collection);
@@ -344,11 +345,10 @@ export class Service<R extends Resource = Resource> {
             success => {
                 // this create a new ID for every resource (for caching proposes)
                 // for example, two URL return same objects but with different attributes
-                // tslint:disable-next-line:deprecation
                 if (params.cachehash) {
                     Object.keys(success.data).forEach((key): void => {
                         let resource: any = success.data[key];
-                        // eslint-disable-next-line deprecation
+                        // eslint-disable-next-line
                         resource.id = resource.id + params.cachehash;
                     });
                 }