fix: fix unit tests based on the changed defaults

Author: jorainer

R/retry_download.R

@@ -1,5 +1,5 @@
 #' Retry an expression `ntimes` times waiting an increasing amount of time
-#' between tries, i.e. waiting for `Sys.sleep(i * sleep_mult)` seconds between
+#' between tries, i.e., waiting for `Sys.sleep(i * sleep_mult)` seconds between
 #' each try. If `expr` fails for `ntimes` times the error will be thrown.
 #'
 #' @param expr Expression to be evaluated.
@@ -18,7 +18,7 @@
 #' @importFrom methods is
 #'
 #' @noRd
-.retry <- function(expr, ntimes = 5, sleep_mult = 0) {
+.retry <- function(expr, ntimes = 5L, sleep_mult = 0L) {
     res <- NULL
     for (i in seq_len(ntimes)) {
         res <- suppressWarnings(tryCatch(expr, error = function(e) e))
@@ -32,5 +32,5 @@
 }
 
 .sleep_mult <- function() {
-    as.integer(getOption("metabolights.sleep_mult", default = 7))
+    as.integer(getOption("metabolights.sleep_mult", default = 7L))
 }

tests/testthat/test_retry_download.R

@@ -4,13 +4,14 @@ test_that(".retry works", {
             stop("A, got a 0")
         1
     }
-
     set.seed(123)
-    expect_error(.retry(a()), "A, got a 0")
-    res <- .retry(a())
+    res <- .retry(a(), ntimes = 5L)
     expect_equal(res, 1)
+    ## Failure
+    set.seed(123)
+    expect_error(.retry(a(), ntimes = 3L), "A, got a 0")
 })
 
 test_that(".sleep_mult works", {
-    expect_equal(.sleep_mult(), 5L)
+    expect_equal(.sleep_mult(), 7L)
 })