Skip to content

Commit ffc2334

Browse files
committed
ci(premerge): update premerge checks
1 parent 4ea5eb1 commit ffc2334

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

.github/actions/setup-environment/action.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,14 @@ runs:
1919
rm -rf "$VENV"
2020
case $VENV in
2121
*py311*)
22+
sudo add-apt-repository ppa:deadsnakes/ppa
23+
sudo apt update
2224
sudo apt install -y python3.11 python3.11-venv
2325
python3.11 -m venv "$VENV"
2426
;;
2527
*py312*)
28+
sudo add-apt-repository ppa:deadsnakes/ppa
29+
sudo apt update
2630
sudo apt install -y python3.12 python3.12-venv
2731
python3.12 -m venv "$VENV"
2832
;;
@@ -33,8 +37,8 @@ runs:
3337
esac
3438
source "$VENV/bin/activate"
3539
python3 --version
36-
if [ "$INSTALL" = "true" ]; then \
37-
python3 -m pip install --quiet -r requirements.txt \
40+
if [ "$INSTALL" = "true" ]; then
41+
python3 -m pip install --quiet -r requirements.txt
3842
fi
3943
env:
4044
VENV: ${{ inputs.venv }}

.github/workflows/validate-codeowners.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- name: Get codeowners
2929
id: codeowners
3030
run: |
31-
RESULT=$(bash tools/shell/actions/codeowners/codeowners.sh)
31+
RESULT=$(bash tools/actions/codeowners/codeowners.sh)
3232
echo "matrix=$RESULT" >> $GITHUB_OUTPUT
3333
echo "$RESULT"
3434

.github/workflows/validate-pr.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ jobs:
1919
outputs:
2020
codeowners-change: ${{ steps.codeowners-change.outputs.change }}
2121
src-change: ${{ steps.src-change.outputs.change }}
22+
requirements-change: ${{ steps.requirements-change.outputs.change }}
2223
shelltools-change: ${{ steps.shelltools-change.outputs.change }}
2324

2425
steps:
@@ -40,6 +41,12 @@ jobs:
4041
with:
4142
pattern: '^src'
4243

44+
- name: Requirements change
45+
id: requirements-change
46+
uses: ./.github/actions/check-changes
47+
with:
48+
pattern: '^requirements.txt'
49+
4350
- name: Shell tools change
4451
id: shelltools-change
4552
uses: ./.github/actions/check-changes
@@ -102,7 +109,7 @@ jobs:
102109
ref: ${{ github.event.pull_request.head.sha }}
103110

104111
- name: Setup environment
105-
uses: ./.github/actions/check-changes
112+
uses: ./.github/actions/setup-environment
106113
with:
107114
venv: ${{ matrix.venv }}
108115

@@ -113,15 +120,15 @@ jobs:
113120
shellcheck tools/actions/**/*.sh
114121
115122
- name: Lint source code
116-
if: needs.checks.outputs.src-change == 'true'
123+
if: ${{ needs.checks.outputs.src-change == 'true' || needs.checks.outputs.requirements-change == 'true'}}
117124
run: |
118125
source "$VENV/bin/activate"
119126
black ./src/ --check
120127
deactivate
121128
122129
- name: Set failure
123130
id: check
124-
if: ${{ failure() || cencelled() }}
131+
if: ${{ failure() || cancelled() }}
125132
run: echo "success=$(echo 'false')" >> $GITHUB_OUTPUT
126133

127134
premerge:

src/init.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
)
2222

2323
doc_splits = text_splitter.split_documents(docs_list)
24+
# https://python.langchain.com/docs/integrations/vectorstores/neo4jvector/
2425
vector_store = Neo4jVector.from_documents(
2526
documents=doc_splits,
2627
embedding=OllamaEmbeddings(

0 commit comments

Comments
 (0)