-
Notifications
You must be signed in to change notification settings - Fork 247
Description
Sources of acquisition of the source code
- this repository
$ git clone https://github.com/rfxn/linux-malware-detect.git
$ ls
linux-malware-detect
- the rfxn.com site
$ curl -C - -LO https://www.rfxn.com/downloads/maldetect-current.tar.gz && tar xvzf maldetect-current.tar.gz
$ ls
maldetect-1.6.6
Hello. It all starts with the inconsistency in naming the extracted root source code folder. Needless to say, consistency is a good rule, thus justifying the naming of this folder, as models "linux-malware-detect_v.1.6.6.1" and "maldetect_v.1.6.6.1".
Yet the lack of consistency isn't the only issue. Whether it's the lack of a version number or the imprecision of the version number in the root folder name, this hinders any ability to determine the code version during acquisition. I myself struggle to find a tangible motive that justifies such a practice.
In code
And the lack of precision in the release version number of the root folder name continues to be observable even in the code itself.
$ type maldet # on Bash Shell
maldet is hashed (/usr/local/bin/maldet)
$ maldet | head -1
Linux Malware Detect v1.6.6
$ cat -n /usr/local/maldetect/README
1 Linux Malware Detect v1.6.6
Relying on the CHANGELOG file in order to determine the release version number should not be a last resort option.
$ cat -n /usr/local/maldetect/CHANGELOG
1 v1.6.6.1 | Feb 25 2025: