Skip to content
This repository was archived by the owner on Nov 10, 2017. It is now read-only.

Commit c9d1992

Browse files
committed
Merge pull request #341 from WonderCsabo/340_platformProvidedDepsNotRemoved
Fix not removed platform provided dependencies
2 parents d5471f4 + fca9a94 commit c9d1992

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

me.gladwell.eclipse.m2e.android.test/src/me/gladwell/eclipse/m2e/android/test/ApplicationAndroidMavenPluginTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public void testConfigureAddsCompileDependenciesToClasspath() throws Exception {
122122
}
123123

124124
public void testConfigureDoesNotAddPlatformDependencyToClasspath() throws Exception {
125-
assertClasspathDoesNotContain(javaProject, "android-2.3.3.jar");
125+
assertClasspathDoesNotContain(javaProject, "android-4.3.1_r3.jar");
126126
}
127127

128128
public void testConfigureDoesNotAddPlatformProvidedDependenciesToClasspath() throws Exception {

me.gladwell.eclipse.m2e.android/src/main/java/me/gladwell/eclipse/m2e/android/configuration/PrunePlatformProvidedDependenciesClasspathLoader.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
import me.gladwell.eclipse.m2e.android.project.MavenAndroidProject;
1919

2020
import org.apache.maven.project.MavenProject;
21+
import org.eclipse.core.runtime.CoreException;
22+
import org.eclipse.core.runtime.NullProgressMonitor;
2123
import org.eclipse.jdt.core.IClasspathEntry;
2224
import org.eclipse.jdt.core.IJavaProject;
2325
import org.eclipse.m2e.core.project.IMavenProjectFacade;
@@ -46,8 +48,9 @@ public Iterable<IClasspathEntry> load(IJavaProject project) throws FileNotFoundE
4648

4749
IMavenProjectFacade facade = projectRegistry.getProject(project.getProject());
4850
if(facade != null) {
49-
MavenProject mavenProject = facade.getMavenProject();
50-
if (mavenProject != null) {
51+
try {
52+
MavenProject mavenProject = facade.getMavenProject(new NullProgressMonitor());
53+
5154
final MavenAndroidProject androidProject = mavenProjectFactory.createAndroidProject(mavenProject);
5255
final List<String> platformProvidedDependencies = androidProject.getPlatformProvidedDependencies();
5356

@@ -65,6 +68,8 @@ public boolean apply(IClasspathEntry entry) {
6568

6669
return prunedNonRuntimeDependencies;
6770
}
71+
} catch (CoreException e) {
72+
throw new ProjectConfigurationException(e);
6873
}
6974
} else {
7075
warn("maven project not yet registered for " + project);

0 commit comments

Comments
 (0)