Skip to content

Traceback when trying to fetch the Logo svg #693

@hwprinz

Description

@hwprinz

@rgthree
as the one in #692 already stated.

Traceback (most recent call last):
  File "D:\Comfy_UI\ComfyUI_windows_portable2\python_embeded\Lib\site-packages\aiohttp\web_protocol.py", line 510, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\python_embeded\Lib\site-packages\aiohttp\web_app.py", line 569, in _handle
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\python_embeded\Lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\ComfyUI\middleware\cache_middleware.py", line 27, in cache_control
    response: web.Response = await handler(request)
                             ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\ComfyUI\server.py", line 83, in deprecation_warning
    response: web.Response = await handler(request)
                             ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\ComfyUI\server.py", line 173, in origin_only_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\ComfyUI\custom_nodes\ComfyUI-Lora-Manager\py\middleware\csp_middleware.py", line 26, in relax_csp_for_remote_media
    response: web.StreamResponse = await handler(request)
                                   ^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\ComfyUI\custom_nodes\rgthree-comfy\py\server\routes_config.py", line 67, in get_logo_markup
    return await get_logo(request, as_markup=True)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\Comfy_UI\ComfyUI_windows_portable2\ComfyUI\custom_nodes\rgthree-comfy\py\server\routes_config.py", line 48, in get_logo
    resp = svg.format(bg=bg, fg=fg)
           ^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: unexpected '{' in field name

but the 'fault' is in pyproject.py

i've used Claude to help to fully analyse, since at some point my skills end...

LOGO_SVG = re.sub(r'(id="bg".*fill=)"[^\"]+"', r'\1"{bg}"', LOGO_SVG)
LOGO_SVG = re.sub(r'(id="fg".*fill=)"[^\"]+"', r'\1"{fg}"', LOGO_SVG)

but even without fixing the code at that point
the timeout you've obv cut out from older versions in the aiohttp request
would fix it also again, when putting back

Feel free to read the lot
https://claude.ai/share/7d214153-b215-4fa2-9724-0dfa3ba7b567

regards /Hans

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions