Remove getMemBasePlusOffset inversion logic after llvm#125279

Author: rgwott

llvm/include/llvm/CodeGen/SelectionDAG.h

@@ -1073,8 +1073,7 @@ class SelectionDAG {
   SDValue getMemBasePlusOffset(SDValue Base, TypeSize Offset, const SDLoc &DL,
                                const SDNodeFlags Flags = SDNodeFlags());
   SDValue getMemBasePlusOffset(SDValue Base, SDValue Offset, const SDLoc &DL,
-                               const SDNodeFlags Flags = SDNodeFlags(),
-                               const bool Inverted = false);
+                               const SDNodeFlags Flags = SDNodeFlags());
 
   /// Create an add instruction with appropriate flags when used for
   /// addressing some offset of an object. i.e. if a load is split into multiple

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

@@ -8069,19 +8069,14 @@ SDValue SelectionDAG::getMemBasePlusOffset(SDValue Base, TypeSize Offset,
 
 SDValue SelectionDAG::getMemBasePlusOffset(SDValue Ptr, SDValue Offset,
                                            const SDLoc &DL,
-                                           const SDNodeFlags Flags,
-                                           const bool Inverted) {
+                                           const SDNodeFlags Flags) {
   assert(Offset.getValueType().isInteger());
   EVT BasePtrVT = Ptr.getValueType();
   if (!this->getTarget().shouldPreservePtrArith(
           this->getMachineFunction().getFunction())) {
     return getNode(ISD::ADD, DL, BasePtrVT, Ptr, Offset, Flags);
   } else {
-    if (Inverted) {
-      return getNode(ISD::PTRADD, DL, BasePtrVT, Offset, Ptr, Flags);
-    } else {
-      return getNode(ISD::PTRADD, DL, BasePtrVT, Ptr, Offset, Flags);
-    }
+    return getNode(ISD::PTRADD, DL, BasePtrVT, Ptr, Offset, Flags);
   }
 }
 

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

@@ -4501,7 +4501,7 @@ void SelectionDAGBuilder::visitAlloca(const AllocaInst &I) {
   // an address inside an alloca.
   AllocSize = DAG.getMemBasePlusOffset(
       AllocSize, DAG.getConstant(StackAlignMask, dl, IntPtr), dl,
-      SDNodeFlags::NoUnsignedWrap, true);
+      SDNodeFlags::NoUnsignedWrap);
 
   // Mask out the low bits for alignment purposes.
   AllocSize = DAG.getNode(ISD::AND, dl, AllocSize.getValueType(), AllocSize,