Apply various IntelliJ autofixes. This is absolutely safe. (#731)

Author: jiridanek

broker/src/test/java/util/Broker.java

@@ -46,9 +46,9 @@
 public class Broker implements AutoCloseable, ExtensionContext.Store.CloseableResource {
     // Use same MBeanServer instance that broker is using (don't create new)
     private final MBeanServer mBeanServer = ManagementFactory.getPlatformMBeanServer();
-    public Path tempDir;
-    public EmbeddedActiveMQ embeddedBroker = new EmbeddedActiveMQ();
-    public Configuration configuration = new ConfigurationImpl();
+    public final Path tempDir;
+    public final EmbeddedActiveMQ embeddedBroker = new EmbeddedActiveMQ();
+    public final Configuration configuration = new ConfigurationImpl();
 
     public Broker() {
         this(null);
@@ -178,9 +178,9 @@ private int findRandomAvailablePortOnAllLocalInterfaces() throws IOException {
         }
     }
 
-    protected Object createProxy(final ObjectName objectName,
-                                 final Class mbeanInterface,
-                                 final MBeanServer mbeanServer) {
+    protected <T> Object createProxy(final ObjectName objectName,
+                                     final Class<T> mbeanInterface,
+                                     final MBeanServer mbeanServer) {
         return MBeanServerInvocationHandler.newProxyInstance(mbeanServer, objectName, mbeanInterface, false);
     }
 

cli-activemq-jmx/src/main/java/com/redhat/amqx/formatters/PythonFormatter.java

@@ -14,7 +14,7 @@ public class PythonFormatter implements Formatter {
      */
     public String convertJSON(String json) {
         // TODO for serialization from JSON to java object use jackson json library
-        json = json.replaceAll("\"", "\'");
+        json = json.replaceAll("\"", "'");
         json = json.replaceAll(":", ": ");
         json = json.replaceAll(",'", ", '");
         json = json.replaceAll("'?[Nn]one'?", "None");

cli-activemq-jmx/src/main/java/com/redhat/amqx/main/BrokerType.java

@@ -8,9 +8,9 @@ public enum BrokerType {
     ARTEMIS("service:jmx:rmi:///jndi/rmi://localhost:1099/jmxrmi", "amq", "artemis"),
     ACTIVEMQ("service:jmx:rmi:///jndi/rmi://localhost:1099/karaf-root", "amq", "activemq");
 
-    private String defaultJMXURL;
-    private String defaultBrokerName;
-    private String defaultUpstreamName;
+    private final String defaultJMXURL;
+    private final String defaultBrokerName;
+    private final String defaultUpstreamName;
 
     BrokerType(String defaultJMXURL, String defaultBrokerName, String upstreamName) {
         this.defaultJMXURL = defaultJMXURL;

cli-activemq-jmx/src/main/java/com/redhat/amqx/main/Main.java

@@ -19,7 +19,7 @@ public class Main {
     private static void help(int code) {
         System.out.println("Usage: amqx <object> --host <brokerIp>:<port> --action <action> [--name <destinationName>]\n");
 
-        System.out.printf("Objects:    {%s, %s, %s, %s}\n", DESTINATION, JMS_TOPIC, ADDRESS, BROKER, DIVERT);
+        System.out.printf("Objects:    {%s, %s, %s, %s, %s}\n", DESTINATION, JMS_TOPIC, ADDRESS, BROKER, DIVERT);
         System.out.printf("Actions:    Destination {%s, %s, %s, %s}\n", QueueAction.ADD_ACTION,
             QueueAction.REMOVE_ACTION, QueueAction.LIST_ACTION, QueueAction.PROPERTIES_ACTION);
         // TODO finish broker actions

cli-activemq-jmx/src/main/java/com/redhat/amqx/main/NodeType.java

@@ -9,7 +9,7 @@ public enum NodeType {
     QUEUE("Queue"),
     DIVERT("Divert");
 
-    private String nodeTypeString;
+    private final String nodeTypeString;
 
     NodeType(final String nodeTypeString) {
         this.nodeTypeString = nodeTypeString;

cli-activemq-jmx/src/main/java/com/redhat/amqx/main/actions/AddressAction.java

@@ -64,7 +64,7 @@ protected void processCommand(String[] args) {
         setCredentials(cmdLine);
         setLogLevel(cmdLine.getOptionValue("log-level", DEFAULT_LOGGING_LEVEL));
 
-        if (routingType.toLowerCase().equals("multicast")) {
+        if (routingType.equalsIgnoreCase("multicast")) {
             routingType = RoutingType.MULTICAST.toString();
         } else {
             routingType = RoutingType.ANYCAST.toString();

cli-activemq-jmx/src/main/java/com/redhat/amqx/main/actions/DivertAction.java

@@ -3,15 +3,12 @@
 import com.redhat.amqx.main.BrokerType;
 import com.redhat.amqx.management.ManagerFactory;
 import com.redhat.amqx.management.artemis.DivertArtemisManager;
-import com.redhat.amqx.management.exception.DestinationException;
-import org.apache.activemq.artemis.api.core.RoutingType;
 import org.apache.activemq.artemis.core.server.ComponentConfigurationRoutingType;
 import org.apache.commons.cli.CommandLine;
 import org.apache.commons.cli.CommandLineParser;
 import org.apache.commons.cli.DefaultParser;
 import org.apache.commons.cli.ParseException;
 
-import javax.print.attribute.standard.Destination;
 import java.io.IOException;
 
 /**

cli-activemq-jmx/src/main/java/com/redhat/amqx/management/AbstractConnectionManager.java

@@ -19,8 +19,8 @@
  */
 public abstract class AbstractConnectionManager {
     private static final Logger logger = LoggerFactory.getLogger(AbstractConnectionManager.class);
-    private Resolver<?, ?, ?, ?, ?> resolver;
-    private String brokerName;
+    private final Resolver<?, ?, ?, ?, ?> resolver;
+    private final String brokerName;
     private JMXServiceURL jmxServiceURL;
     protected MBeanServerConnection mBeanServerConnection;
 
@@ -34,7 +34,7 @@ public AbstractConnectionManager(String url, final Credentials credentials, Stri
         // else { use default url};
         jmxServiceURL = new JMXServiceURL(url);
 
-        if (brokerName == null || brokerName.equals("")) {
+        if (brokerName == null || brokerName.isEmpty()) {
             this.brokerName = brokerType.getDefaultBrokerName();
         } else {
             this.brokerName = brokerName;

cli-activemq-jmx/src/main/java/com/redhat/amqx/management/Credentials.java

@@ -4,8 +4,8 @@
  * Implements basic credentials used for authentication
  */
 public class Credentials {
-    private String username;
-    private String password;
+    private final String username;
+    private final String password;
 
     public Credentials(String username, String password) {
         this.username = username;

cli-activemq-jmx/src/main/java/com/redhat/amqx/management/ManagerFactory.java

@@ -49,7 +49,7 @@ public BrokerManager createBrokerManager(String jmxURL, Credentials credentials,
     }
 
     private String checkBrokerName(String brokerName, BrokerType brokerType) {
-        if (brokerName == null || brokerName.equals("")) {
+        if (brokerName == null || brokerName.isEmpty()) {
             brokerName = brokerType.getDefaultBrokerName();
         }
         return brokerName;
@@ -62,7 +62,7 @@ private String checkBrokerName(String brokerName, BrokerType brokerType) {
      * @return brokerType to be used from parameters
      */
     private BrokerType resolveBrokerType(String brokerTypeName) {
-        if (brokerTypeName == null || brokerTypeName.equals("")) {
+        if (brokerTypeName == null || brokerTypeName.isEmpty()) {
             return BrokerType.ARTEMIS;
         } else {
             brokerTypeName = brokerTypeName.toUpperCase().trim();