Skip to content

Commit 4a65195

Browse files
committed
Merge changes from upstream
2 parents b566af7 + a94e58b commit 4a65195

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

modules/jlink/tests/features/jlink.feature

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,10 @@ Scenario: Ensure S2I_ENABLE_JLINK is not set to true
1212
Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.0.1.Final-nos2i
1313
Then container log should not contain S2I_ENABLE_JLINK=true
1414
And run bash -c "test ! -d /tmp/jre && echo PASS" in container and immediately check its output for PASS
15+
16+
Scenario: Check that /tmp/jre/bin/java and /tmp/jre/lib/modules exist post s2i build if jlink is enabled.
17+
Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.9.2-uberjar
18+
| variable | value |
19+
| S2I_ENABLE_JLINK | true |
20+
Then container log should contain S2I_ENABLE_JLINK=true
21+
and run bash -c "test -d /tmp/jre/bin/java && test -d /tmp/jre/lib/modules && echo PASS" in container and immediately check its output for PASS

templates/jlink/README.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,21 +75,19 @@ See all the OpenShift objects that were created:
7575

7676
## Stage 3: Kick off builds
7777

78-
There will be three BuildConfigs, called something like
78+
Instantiating the template will cause 3 separate BuildConfigs to be created and will automatically start their builds in sequence:
7979

80-
1. $APPNAME-jlink-builder-jdk-21
81-
2. $APPNAME-jlink-s2i-jdk-21
80+
1. $APPNAME-jlink-builder-jdk-$JDK_VERSION
81+
2. $APPNAME-jlink-s2i-jdk-$JDK_VERSION
8282
3. $APPNAME-multistage-buildconfig
8383

84-
Where $APPNAME is the parameter initially passed to the template.
84+
Where $APPNAME and $JDK_VERSION are the paremeters initially passed to the template.
8585

86-
Start a build for (1). Once complete, builds for (2) and (3) should be
87-
automatically triggered in sequence.
86+
A build will automatically start for (1). Once complete, builds for (2) and (3) should be automatically triggered in sequence.
8887

8988
## Stage 4: create deployment
9089

91-
The ImageStreamTag `$APPNAME-lightweight-image:latest` will be populated with the new
92-
application container image.
90+
The ImageStreamTag `$APPNAME-lightweight-image:latest` will be populated with the new application container image.
9391

9492
Create a deployment to see it work. E.g., in the Developer Perspective, select
9593
"+Add", "Container Images", "Image stream tag from internal registry", ...,

0 commit comments

Comments
 (0)