[OPENJDK-631] adjust S2I_SOURCE_DEPLOYMENTS_FILTER for Quarkus

Alter the default value of S2I_SOURCE_DEPLOYMENTS_FILTER from
"*.jar" to "*.jar quarkus-app". For the default Quarkus build
layout (fast jar), these are the required path components to copy
out of the build directory (target).

There is a very low risk that a non-quarkus app has a path
matching quarkus-app in its build directory which should not be
copied into the resulting image. The mitigation in such a scenario
is to override S2I_SOURCE_DEPLOYMENTS_FILTER.

Remove the duplicate definition of S2I_SOURCE_DEPLOYMENTS_FILTER
from modules/s2i/bash/module.yaml, retaining only the one in
modules/s2i/core/module.yaml. The reason for the duplication is
historical: other products overrode the value with different
defaults (* -> *.jar for us; *.war for JWS, etc.) in other modules.

Signed-off-by: Jonathan Dowland <[email protected]>

Author: jmtd

modules/s2i/bash/module.yaml

@@ -6,8 +6,6 @@ description: Customization of common Maven S2I for Java S2I image.
 envs:
 - name: JBOSS_CONTAINER_JAVA_S2I_MODULE
   value: /opt/jboss/container/java/s2i
-- name: S2I_SOURCE_DEPLOYMENTS_FILTER
-  value: "*.jar"
 
 execute:
 - script: configure.sh

modules/s2i/core/module.yaml

@@ -78,8 +78,8 @@ envs:
 - name: S2I_SOURCE_DEPLOYMENTS_FILTER
   description: >
     Space separated list of filters to be applied when copying deployments.
-    Defaults to ** * **
-  value: "*"
+    Defaults to ** *.jar quarkus-app **
+  value: "*.jar quarkus-app"
   example: "*.jar *.war *.ear"
 
 - name: S2I_TARGET_DEPLOYMENTS_DIR