Skip to content

Commit 8340fae

Browse files
committed
Tests: de-couple Jolokia testing from other Behave features
Ports check was erroneously checking that the Jolokia port was open (and wasn't checking 8443). Fix that and remove the Jolokia metadata port check (which is already duplicated over in the Jolokia feature) Don't check for Jolokia in container log test in the runtime feature. Adjust the Jolokia test tagging to cover the correct OpenJDK images. Also: fix the test! IT did not specify the starting conditions for a container. Add a new Jolokia feature that replicates the "runtime" test but only the Jolokia-specific log check. Signed-off-by: Jonathan Dowland <[email protected]>
1 parent 6e4f542 commit 8340fae

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed

tests/features/java/ports.feature

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ Feature: Openshift OpenJDK port tests
88
Scenario: Check ports are available
99
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
1010
Then check that port 8080 is open
11-
Then check that port 8778 is open
11+
Then check that port 8443 is open
1212
Then inspect container
1313
| path | value |
1414
| /Config/ExposedPorts | 8080/tcp |
1515
| /Config/ExposedPorts | 8443/tcp |
16-
| /Config/ExposedPorts | 8778/tcp |

tests/features/java/runtime.feature

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,3 @@ Feature: Openshift OpenJDK Runtime tests
3232
| JAVA_DIAGNOSTICS | true |
3333
Then container log should contain /deployments/undertow-servlet.jar Hello from CTF test
3434
And container log should contain -XX:NativeMemoryTracking=summary
35-
And container log should contain Jolokia: Agent started

tests/features/jolokia.feature

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,25 @@ Feature: Openshift OpenJDK Jolokia tests
66
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
77
Then run sh -c 'unzip -q -p /usr/share/java/jolokia-jvm-agent/jolokia-jvm.jar META-INF/maven/org.jolokia/jolokia-jvm/pom.properties | grep -F ${JOLOKIA_VERSION}' in container and check its output for version=
88

9-
@jboss-decisionserver-6
10-
@jboss-processserver-6
11-
@jboss-webserver-3/webserver30-tomcat7-openshift
12-
@jboss-webserver-3/webserver31-tomcat7-openshift
13-
@jboss-webserver-3/webserver30-tomcat8-openshift
14-
@jboss-webserver-3/webserver31-tomcat8-openshift
15-
@jboss-amq-6
9+
@openjdk
10+
@ubi8/openjdk-8
11+
@ubi8/openjdk-11
12+
@redhat-openjdk-18
1613
Scenario: Check jolokia port is available
17-
When container is ready
14+
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
1815
Then check that port 8778 is open
19-
Then inspect container
16+
And inspect container
2017
| path | value |
2118
| /Config/ExposedPorts | 8778/tcp |
19+
20+
@openjdk
21+
@ubi8/openjdk-8
22+
@ubi8/openjdk-11
23+
@redhat-openjdk-18
24+
Scenario: Ensure Jolokia diagnostic options work correctly
25+
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
26+
| variable | value |
27+
| JAVA_ARGS | Hello from CTF test |
28+
| JAVA_DIAGNOSTICS | true |
29+
Then container log should contain /deployments/undertow-servlet.jar Hello from CTF test
30+
And container log should contain Jolokia: Agent started

0 commit comments

Comments
 (0)