Skip to content

Commit ad3f1a4

Browse files
committed
[OPENJDK-3653] install s2i scripts to libexec
This is the conventional path for the scripts. Signed-off-by: Jonathan Dowland <[email protected]>
1 parent 7b635be commit ad3f1a4

File tree

13 files changed

+11
-16
lines changed

13 files changed

+11
-16
lines changed

modules/maven/s2i/configure.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ARTIFACTS_DIR=${SCRIPT_DIR}/artifacts
88
chown -R $USER:root $SCRIPT_DIR
99
chmod -R ug+rwX $SCRIPT_DIR
1010
chmod ug+x ${ARTIFACTS_DIR}/opt/jboss/container/maven/s2i/*
11-
chmod ug+x ${ARTIFACTS_DIR}/usr/local/s2i/*
11+
chmod ug+x ${ARTIFACTS_DIR}/usr/libexec/s2i/*
1212

1313
pushd ${ARTIFACTS_DIR}
1414
cp -pr * /

modules/run/tests/features/java.runtime.feature

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ Feature: Openshift OpenJDK Runtime tests (OPENJDK-474, OPENJDK-2805)
1010
| JAVA_DIAGNOSTICS | true |
1111
Then container log should contain /deployments/undertow-servlet.jar unique
1212
And container log should contain -XX:NativeMemoryTracking=summary
13-
And file /usr/local/s2i/run should exist
14-
And file /usr/local/s2i/run should not contain JVM_ARGS
1513
And file /usr/libexec/s2i/run should exist
1614
And file /usr/libexec/s2i/run should not contain JVM_ARGS
1715
And container log should not contain unique unique

modules/s2i/bash/configure.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ ARTIFACTS_DIR=${SCRIPT_DIR}/artifacts
88
chown -R $USER:root $SCRIPT_DIR
99
chmod -R ug+rwX $SCRIPT_DIR
1010
chmod ug+x ${ARTIFACTS_DIR}/opt/jboss/container/java/s2i/*
11-
chmod ug+x ${ARTIFACTS_DIR}/usr/local/s2i/*
11+
chmod ug+x ${ARTIFACTS_DIR}/usr/libexec/s2i/*
1212

1313
pushd ${ARTIFACTS_DIR}
1414
cp -pr * /

modules/s2i/core/configure.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,6 @@ pushd ${ARTIFACTS_DIR}
1313
cp -pr * /
1414
popd
1515

16-
mkdir -p /usr/local/s2i \
17-
&& chmod 775 /usr/local/s2i \
18-
&& chown -R $USER:root /usr/local/s2i
19-
20-
# OPENJDK-2805
21-
ln -s /usr/local/s2i /usr/libexec/s2i
22-
2316
mkdir -p /deployments \
2417
&& chmod -R "ug+rwX" /deployments \
2518
&& chown -R $USER:root /deployments

modules/s2i/core/module.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@ packages:
1212
- rsync
1313

1414
labels:
15+
# XXX this modules does not install files in this path
1516
- name: "io.openshift.s2i.scripts-url"
16-
value: "image:///usr/local/s2i"
17+
value: "image:///usr/libexec/s2i"
1718
- name: io.openshift.s2i.destination
1819
value: "/tmp"
1920
- name: org.jboss.container.deployments-dir
@@ -114,7 +115,8 @@ envs:
114115

115116
run:
116117
cmd:
117-
- "/usr/local/s2i/run"
118+
# XXX this script is in a different module
119+
- "/usr/libexec/s2i/run"
118120

119121
modules:
120122
install:

0 commit comments

Comments
 (0)