Skip to content

Commit bdd34f3

Browse files
committed
Default GC to UseParallelGC, not UseParallelOldGC
The -XX:+UseParallelOldGC flag has been removed in JDK 17+. For JDKs 8, 11 and 17, passing -XX:UseParallelGC instead is equivalent in terms of the effect it has. Replace all occurences of the former with the latter. Signed-off-by: Jonathan Dowland <[email protected]>
1 parent fdb5157 commit bdd34f3

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

modules/jvm/api/module.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ envs:
5555
description: The maximum metaspace size.
5656
example: "100"
5757
- name: GC_CONTAINER_OPTIONS
58-
description: specify Java GC to use. The value of this variable should contain the necessary JRE command-line options to specify the required GC, which will override the default of `-XX:+UseParallelOldGC`.
58+
description: specify Java GC to use. The value of this variable should contain the necessary JRE command-line options to specify the required GC, which will override the default of `-XX:+UseParallelGC`.
5959
example: -XX:+UseG1GC
6060
# deprecated
6161
- name: JAVA_OPTIONS

modules/jvm/bash/artifacts/opt/jboss/container/java/jvm/java-default-options

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ gc_config() {
135135
local maxHeapFreeRatio=${GC_MAX_HEAP_FREE_RATIO:-20}
136136
local timeRatio=${GC_TIME_RATIO:-4}
137137
local adaptiveSizePolicyWeight=${GC_ADAPTIVE_SIZE_POLICY_WEIGHT:-90}
138-
local gcOptions="${GC_CONTAINER_OPTIONS:--XX:+UseParallelOldGC}"
138+
local gcOptions="${GC_CONTAINER_OPTIONS:--XX:+UseParallelGC}"
139+
139140
# for compat reasons we don't set a default value for metaspaceSize
140141
local metaspaceSize
141142
# We also don't set a default value for maxMetaspaceSize

tests/features/java/gc.feature

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,48 +7,48 @@ Feature: Openshift OpenJDK GC tests
77

88
Scenario: Check default GC configuration
99
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
10-
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
11-
And container log should contain -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
10+
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
11+
And container log should contain -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
1212

1313
Scenario: Check GC_MIN_HEAP_FREE_RATIO GC configuration
1414
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
1515
| variable | value |
1616
| GC_MIN_HEAP_FREE_RATIO | 5 |
17-
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
18-
And container log should contain -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
17+
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelGC -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
18+
And container log should contain -XX:+UseParallelGC -XX:MinHeapFreeRatio=5 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
1919

2020
Scenario: Check GC_MAX_HEAP_FREE_RATIO GC configuration
2121
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
2222
| variable | value |
2323
| GC_MAX_HEAP_FREE_RATIO | 50 |
24-
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=50 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
25-
And container log should contain -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=50 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
24+
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=50 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
25+
And container log should contain -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=50 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
2626

2727
Scenario: Check GC_TIME_RATIO GC configuration
2828
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
2929
| variable | value |
3030
| GC_TIME_RATIO | 5 |
31-
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=5 -XX:AdaptiveSizePolicyWeight=90
32-
And container log should contain -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=5 -XX:AdaptiveSizePolicyWeight=90
31+
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=5 -XX:AdaptiveSizePolicyWeight=90
32+
And container log should contain -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=5 -XX:AdaptiveSizePolicyWeight=90
3333

3434
Scenario: Check GC_ADAPTIVE_SIZE_POLICY_WEIGHT GC configuration
3535
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
3636
| variable | value |
3737
| GC_ADAPTIVE_SIZE_POLICY_WEIGHT | 80 |
38-
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=80
39-
And container log should contain -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=80
38+
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=80
39+
And container log should contain -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=80
4040

4141
Scenario: Check GC_MAX_METASPACE_SIZE GC configuration
4242
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
4343
| variable | value |
4444
| GC_MAX_METASPACE_SIZE | 120 |
45-
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=120m
46-
And container log should contain -XX:+UseParallelOldGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=120m
45+
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=120m
46+
And container log should contain -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:MaxMetaspaceSize=120m
4747

4848
Scenario: Check GC_CONTAINER_OPTIONS configuration
4949
Given s2i build https://github.com/jboss-openshift/openshift-quickstarts from undertow-servlet
5050
| variable | value |
5151
| GC_CONTAINER_OPTIONS | -XX:+UseG1GC |
5252
Then s2i build log should contain Using MAVEN_OPTS -XX:+UseG1GC
5353
And container log should contain -XX:+UseG1GC
54-
And container log should not contain -XX:+UseParallelOldGC
54+
And container log should not contain -XX:+UseParallelGC

0 commit comments

Comments
 (0)