Merge pull request #366 from chsc-1/patch-1

[OPENJDK-2033] OpenJDK runtime images cannot overwrite JAVA_APP_DIR

Author: jmtd

modules/run/artifacts/opt/jboss/container/java/run/run-env.sh

@@ -1,4 +1,6 @@
 #!/bin/sh
 
-# Set the application dir to the S2I deployment dir
-JAVA_APP_DIR=/deployments
+# Default the application dir to the S2I deployment dir
+if [ -z "$JAVA_APP_DIR" ]
+then JAVA_APP_DIR=/deployments
+fi

modules/run/artifacts/opt/jboss/container/java/run/run-java.sh

@@ -245,6 +245,7 @@ startup() {
   procname="${JAVA_APP_NAME-java}"
 
   log_info "exec -a \"${procname}\" java $(get_java_options) -cp \"$(get_classpath)\" ${args} $*"
+  log_info "running in $PWD"
   exec -a "${procname}" java $(get_java_options) -cp "$(get_classpath)" ${args} $*
 }
 

tests/features/java/runtime.feature

@@ -67,3 +67,29 @@ Feature: Openshift OpenJDK Runtime tests
     | JAVA_OPTIONS | --show-version |
     Then container log should not contain -XX:MaxRAMPercentage
     And  container log should contain --show-version
+
+  @ubi8
+  Scenario: Check default JAVA_APP_DIR (OPENJDK-2033)
+  When container is ready
+  Then available container log should contain INFO running in /deployments
+
+  @ubi8
+  Scenario: Check custom JAVA_APP_DIR (OPENJDK-2033)
+    Given container is started with env
+    | variable     | value       |
+    | JAVA_APP_DIR | /home/jboss |
+  Then available container log should contain INFO running in /home/jboss
+
+  @ubi8
+  Scenario: Check relative path JAVA_APP_DIR (OPENJDK-2033)
+    Given container is started with env
+    | variable     | value  |
+    | JAVA_APP_DIR | .      |
+  Then available container log should contain INFO running in /home/jboss
+
+  @ubi8
+  Scenario: Check non-existent path JAVA_APP_DIR (OPENJDK-2033)
+    Given container is started with env
+    | variable     | value  |
+    | JAVA_APP_DIR | /nope  |
+  Then available container log should contain ERROR No directory /nope found for auto detection