From d38995e4b954e3a10ec0973162abe690c7c895e0 Mon Sep 17 00:00:00 2001 From: jmatsuok Date: Tue, 18 Feb 2025 15:57:19 -0500 Subject: [PATCH 1/2] Add test to check that /tmp/jre exists when jlink is enabled --- modules/jlink/tests/features/jlink.feature | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/modules/jlink/tests/features/jlink.feature b/modules/jlink/tests/features/jlink.feature index 8594a6f0..8e1cba78 100644 --- a/modules/jlink/tests/features/jlink.feature +++ b/modules/jlink/tests/features/jlink.feature @@ -12,3 +12,10 @@ Scenario: Ensure S2I_ENABLE_JLINK is not set to true Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.0.1.Final-nos2i Then container log should not contain S2I_ENABLE_JLINK=true And run bash -c "test ! -d /tmp/jre && echo PASS" in container and immediately check its output for PASS + +Scenario: Check that /tmp/jre/bin/java and /tmp/jre/lib/modules exist post s2i build if jlink is enabled. + Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.0.1.Final-nos2i + | variable | value | + | S2I_ENABLE_JLINK | true | + Then container log should contain S2I_ENABLE_JLINK=true + and run bash -c "test -d /tmp/jre/bin/java && test -d /tmp/jre/lib/modules && echo PASS" in container and immediately check its output for PASS From 6a8f07be18b6617363b06390760957cff61c3542 Mon Sep 17 00:00:00 2001 From: jmatsuok Date: Tue, 18 Feb 2025 16:14:58 -0500 Subject: [PATCH 2/2] Update test application --- modules/jlink/tests/features/jlink.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/jlink/tests/features/jlink.feature b/modules/jlink/tests/features/jlink.feature index 8e1cba78..80956287 100644 --- a/modules/jlink/tests/features/jlink.feature +++ b/modules/jlink/tests/features/jlink.feature @@ -14,7 +14,7 @@ Scenario: Ensure S2I_ENABLE_JLINK is not set to true And run bash -c "test ! -d /tmp/jre && echo PASS" in container and immediately check its output for PASS Scenario: Check that /tmp/jre/bin/java and /tmp/jre/lib/modules exist post s2i build if jlink is enabled. - Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.0.1.Final-nos2i + Given s2i build https://github.com/jboss-container-images/openjdk-test-applications from quarkus-quickstarts/getting-started-3.9.2-uberjar | variable | value | | S2I_ENABLE_JLINK | true | Then container log should contain S2I_ENABLE_JLINK=true