Skip to content

Commit efc71c9

Browse files
rosslagerwallvathpela
authored andcommitted
build: Avoid passing *FLAGS to sub-make
By default, make won't export CFLAGS defined in the top-level makefile to the gnu-efi submake. However, if the caller has CFLAGS set in the environment, it will export the CFLAGS defined in the top-level makefile to the gnu-efi submake (which it uses due to use of "CFLAGS += ..."). The result is that these two commands both compile but give different checksums on the final binary: $ make $ CFLAGS=not-used make Avoid this inconsistency by explicitly unexporting the various *FLAGS from the top-level makefile. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
1 parent 77a2922 commit efc71c9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -400,3 +400,4 @@ archive: tag
400400

401401
export ARCH CC CROSS_COMPILE LD OBJCOPY EFI_INCLUDE EFI_INCLUDES OPTIMIZATIONS
402402
export FEATUREFLAGS WARNFLAGS WERRFLAGS
403+
unexport CFLAGS CPPFLAGS LDFLAGS

0 commit comments

Comments
 (0)