Clean repository URL for error display (#91)

Megan-Wright · web-flow · commit 1fe3713d6c67 · 2020-05-29T14:25:41.000+01:00
diff --git a/pkg/git/repository.go b/pkg/git/repository.go
@@ -223,7 +223,11 @@ func repoName(u string) (string, error) {
 	}
 	parts := strings.Split(parsed.Path, "/")
 	if len(parts) < 3 {
-		return "", fmt.Errorf("could not identify repository name: %s", u)
+		cleanedURL, err := CleanURL(u)
+		if err != nil {
+			return "", errors.New("failed to clean the URL when determining repository name")
+		}
+		return "", fmt.Errorf("could not identify repository name: %s", cleanedURL)
 	}
 	return strings.TrimSuffix(parts[len(parts)-1], ".git"), nil
 }

Original file line number	Diff line number	Diff line change
`@@ -223,7 +223,11 @@ func repoName(u string) (string, error) {`
`223`	`223`	`}`
`224`	`224`	`parts := strings.Split(parsed.Path, "/")`
`225`	`225`	`if len(parts) < 3 {`
`226`		`- return "", fmt.Errorf("could not identify repository name: %s", u)`
	`226`	`+ cleanedURL, err := CleanURL(u)`
	`227`	`+ if err != nil {`
	`228`	`+ return "", errors.New("failed to clean the URL when determining repository name")`
	`229`	`+ }`
	`230`	`+ return "", fmt.Errorf("could not identify repository name: %s", cleanedURL)`
`227`	`231`	`}`
`228`	`232`	`return strings.TrimSuffix(parts[len(parts)-1], ".git"), nil`
`229`	`233`	`}`