Rename package avancement to promotion (#99)

Also remove unnecessary TODO statement.

Author: JustinKuli

pkg/cmd/promote.go

@@ -6,8 +6,8 @@ import (
 	"log"
 
 	"github.com/mitchellh/go-homedir"
-	"github.com/rhd-gitops-example/services/pkg/avancement"
 	"github.com/rhd-gitops-example/services/pkg/git"
+	"github.com/rhd-gitops-example/services/pkg/promotion"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"github.com/tcnksm/go-gitconfig"
@@ -128,7 +128,7 @@ func promoteAction(c *cobra.Command, args []string) error {
 	if err != nil {
 		return fmt.Errorf("unable to establish credentials: %w", err)
 	}
-	return avancement.New(cacheDir, author, avancement.WithDebug(debug), avancement.WithInsecureSkipVerify(insecureSkipVerify), avancement.WithRepoType(repoType)).Promote(service, fromRepo, toRepo, newBranchName, msg, keepCache)
+	return promotion.New(cacheDir, author, promotion.WithDebug(debug), promotion.WithInsecureSkipVerify(insecureSkipVerify), promotion.WithRepoType(repoType)).Promote(service, fromRepo, toRepo, newBranchName, msg, keepCache)
 }
 
 func newAuthor() (*git.Author, error) {

pkg/avancement/pull_request.go pkg/promotion/pull_request.gopkg/avancement/pull_request.go renamed to pkg/promotion/pull_request.go

@@ -1,4 +1,4 @@
-package avancement
+package promotion
 
 import (
 	"fmt"

pkg/avancement/pull_request_test.go pkg/promotion/pull_request_test.gopkg/avancement/pull_request_test.go renamed to pkg/promotion/pull_request_test.go

@@ -1,4 +1,4 @@
-package avancement
+package promotion
 
 import (
 	"testing"

pkg/avancement/service_manager.go pkg/promotion/service_manager.gopkg/avancement/service_manager.go renamed to pkg/promotion/service_manager.go

@@ -1,4 +1,4 @@
-package avancement
+package promotion
 
 import (
 	"context"
@@ -246,7 +246,6 @@ func (s *ServiceManager) cloneRepo(repoURL, branch string) (git.Repo, error) {
 func createPullRequest(ctx context.Context, fromURL, toURL, newBranchName, commitMsg string, client *scm.Client, fromLocal bool) (*scm.PullRequest, error) {
 	prInput, err := makePullRequestInput(fromLocal, fromURL, toURL, newBranchName, commitMsg)
 	if err != nil {
-		// TODO: improve this error message
 		return nil, err
 	}
 

pkg/avancement/service_manager_test.go pkg/promotion/service_manager_test.gopkg/avancement/service_manager_test.go renamed to pkg/promotion/service_manager_test.go

@@ -1,4 +1,4 @@
-package avancement
+package promotion
 
 import (
 	"errors"