Handle to/from URLs without .git suffix (#82)

a-roberts · web-flow · commit ab2c8f174c94 · 2020-05-20T09:45:57.000+01:00
* Handle to/from URLs without .git suffix
diff --git a/pkg/avancement/service_manager.go b/pkg/avancement/service_manager.go
@@ -251,8 +251,8 @@ func createPullRequest(ctx context.Context, fromURL, toURL, newBranchName, commi
 	}
 
 	u, _ := url.Parse(toURL)
-	// take out ".git" at the end
-	pr, _, err := client.PullRequests.Create(ctx, u.Path[1:len(u.Path)-4], prInput)
+	pathToUse := strings.TrimPrefix(strings.TrimSuffix(u.Path, ".git"), "/")
+	pr, _, err := client.PullRequests.Create(ctx, pathToUse, prInput)
 	return pr, err
 }
 

Original file line number	Diff line number	Diff line change
`@@ -251,8 +251,8 @@ func createPullRequest(ctx context.Context, fromURL, toURL, newBranchName, commi`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`u, _ := url.Parse(toURL)`
`254`		`- // take out ".git" at the end`
`255`		`- pr, _, err := client.PullRequests.Create(ctx, u.Path[1:len(u.Path)-4], prInput)`
	`254`	`+ pathToUse := strings.TrimPrefix(strings.TrimSuffix(u.Path, ".git"), "/")`
	`255`	`+ pr, _, err := client.PullRequests.Create(ctx, pathToUse, prInput)`
`256`	`256`	`return pr, err`
`257`	`257`	`}`
`258`	`258`