Skip to content

fix: getSpecs mutated defaultOptions if passed #211 #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathurAditya724 merged 2 commits into from
Jan 20, 2026
Merged

fix: getSpecs mutated defaultOptions if passed #211 #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8fd15
fix: getSpecs mutated defaultOptions if passed #211
matzehecht Jan 14, 2026
d280c6a
fix: added tests
MathurAditya724 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/__tests__/zodv4.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,42 @@ describe("zod v4", () => {

expect(specs).toMatchSnapshot();
});

it("defaultOptions should not cause parameter pollution between routes", async () => {
const app = new Hono()
.get(
"/hello",
describeRoute({}),
validator("query", z.object({ name: z.string() })),
(c) => {
const { name } = c.req.valid("query");
return c.text(`Hello, ${name}!`);
},
)
.get(
"/world",
describeRoute({}),
validator("query", z.object({ greeting: z.string() })),
(c) => {
const { greeting } = c.req.valid("query");
return c.text(`${greeting}, world!`);
},
);

const specs = await generateSpecs(app, {
defaultOptions: {
GET: {},
},
});

// Verify /hello only has 'name' parameter
const helloParams = specs.paths["/hello"]?.get?.parameters;
expect(helloParams).toHaveLength(1);
expect(helloParams?.[0]).toMatchObject({ name: "name", in: "query" });

// Verify /world only has 'greeting' parameter (not 'name' from /hello)
const worldParams = specs.paths["/world"]?.get?.parameters;
expect(worldParams).toHaveLength(1);
expect(worldParams?.[0]).toMatchObject({ name: "greeting", in: "query" });
});
});
7 changes: 4 additions & 3 deletions src/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,9 @@ async function generatePaths<
}
}

const defaultOptionsForThisMethod =
ctx.options.defaultOptions?.[routeMethod];
const defaultOptionsForThisMethod = ctx.options.defaultOptions?.[
routeMethod
] && { ...ctx.options.defaultOptions[routeMethod] };

const { schema: routeSpecs, components = {} } = await getSpec(
middlewareHandler,
Expand Down Expand Up @@ -253,7 +254,7 @@ async function getSpec(

const result = await middlewareHandler.toOpenAPISchema();
const docs: Pick<OpenAPIV3_1.OperationObject, "parameters" | "requestBody"> =
defaultOptions ?? {};
{ ...defaultOptions };

if (
middlewareHandler.target === "form" ||
Expand Down
Loading