Merge pull request #98 from jkonecny12/master-fix-pylint-duplicate-code

Fix pylint duplicate code

Author: jkonecny12

.pylintrc

@@ -60,7 +60,8 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use "--disable=all --enable=classes
 # --disable=W".
-disable=fixme,
+disable=duplicate-code,
+        fixme,
         invalid-name,
         missing-docstring,
         no-self-use,

simpleline/event_loop/__init__.py

@@ -96,12 +96,29 @@ def enqueue_signal(self, signal):
                   signal,
                   signal.source.__class__.__name__)
 
-    @abstractmethod
     def run(self):
         """Starts the event loop."""
         log.debug("Starting main loop")
         self._force_quit = False
 
+        # Start a loop specific code.
+        self._run()
+
+        log.debug("Main loop ended. Running callback if set.")
+
+        if self._quit_callback:
+            cb = self._quit_callback.callback
+            cb(self._quit_callback.args)
+
+    @abstractmethod
+    def _run(self):
+        """Internal implementation of run method.
+
+        Event loop specific implementation goes here.
+        Exit callbacks are not processed here but by the `run` method.
+        """
+        pass
+
     def force_quit(self):
         """Force quit all running event loops.
 

simpleline/event_loop/glib_event_loop.py

@@ -133,18 +133,12 @@ def _quit_all_loops(self):
         for loop_data in reversed(self._event_loops):
             loop_data.loop.quit()
 
-    def run(self):
+    def _run(self):
         """Starts the event loop."""
-        super().run()
         if len(self._event_loops) != 1:
             raise ValueError("Can't run event loop multiple times.")
 
         self._event_loops[0].loop.run()
-        log.debug("Main loop ended. Running callback if set.")
-
-        if self._quit_callback:
-            cb = self._quit_callback.callback
-            cb(self._quit_callback.args)
 
     def force_quit(self):
         """Force quit all running event loops.

simpleline/event_loop/main_loop.py

@@ -54,26 +54,19 @@ def register_signal_source(self, signal_source):
         super().register_signal_source(signal_source)
         self._active_queue.add_source(signal_source)
 
-    def run(self):
+    def _run(self):
         """This methods starts the application.
 
         Do not use self.mainloop() directly as run() handles all the required exceptions
         needed to keep nested mainloop working.
         """
-        super().run()
         self._run_loop = True
 
         try:
             self._mainloop()
         except ExitMainLoop:
             pass
 
-        log.debug("Main loop ended. Running callback if set.")
-
-        if self._quit_callback:
-            cb = self._quit_callback.callback
-            cb(self._quit_callback.args)
-
     def force_quit(self):
         """Force quit all running event loops.