Skip to content

Commit 5d0409d

Browse files
committed
Add Makefile target for local container tests
It is a small wrapper to run tests in a container with a pinned pylint version. The pinned pylint version is required otherwise we would be still fixing pylint issues on this stable branch. Use this new call also in the GH action.
1 parent 696b2ee commit 5d0409d

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.github/workflows/validate.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,4 @@ jobs:
99

1010
- name: Run test
1111
run: |
12-
podman run --rm -v .:/simpleline:Z --workdir /simpleline registry.fedoraproject.org/fedora:rawhide sh -c " \
13-
dnf install -y python3-pylint python3-gobject-base make; \
14-
make ci"
12+
make container-ci

Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,3 +147,9 @@ pypi-upload:
147147

148148
.PHONY: ci
149149
ci: check test
150+
151+
# Run tests in the container but with fixed pylint version
152+
container-ci:
153+
podman run --pull=always --rm -v .:/simpleline:Z --workdir /simpleline quay.io/centos/centos:stream9 sh -c " \
154+
dnf install -y python3-pip python3-gobject-base make && pip3 install pocketlint 'pylint==2.8.3' ; \
155+
make ci"

0 commit comments

Comments
 (0)