Fix SC2181 issues in kdump-udev-throttler

Fix the issues found by shellcheck,

  In kdump-udev-throttler line 30:
  if [ $? -ne 0 ]; then
       ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.

  In kdump-udev-throttler line 37:
  if [ $? -ne 0 ]; then
       ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.

Also add kdump-udev-throttler to shellcheck list for Github Action.

Signed-off-by: Coiby Xu <[email protected]>

Author: coiby

.github/workflows/main.yml

@@ -19,7 +19,7 @@ jobs:
       - run: dnf install shellcheck -y
       # Currently, for kdump-utils, there is need for shellcheck to require
       # the sourced file to give correct warnings about the checked file
-      - run: shellcheck -x *.sh  kdumpctl mk*dumprd
+      - run: shellcheck -x *.sh  kdumpctl mk*dumprd kdump-udev-throttler
       - run: shellcheck -x dracut/*/*.sh
       - run: shellcheck -x tests/*/*/*.sh tools/*.sh
       # disable the follow checks for unit tests

kdump-udev-throttler

@@ -26,15 +26,14 @@ unuse_luks_keys()
 
 	[[ -f $LUKS_CONFIGFS_REUSE ]] || echo 0 > $LUKS_CONFIGFS_REUSE
 }
-exec 9> $throttle_lock
-if [ $? -ne 0 ]; then
+
+if ! exec 9> $throttle_lock; then
 	echo "Failed to create the lock file! Fallback to non-throttled kdump service restart"
 	/bin/kdumpctl reload
 	exit 1
 fi
 
-flock -n 9
-if [ $? -ne 0 ]; then
+if ! flock -n 9; then
 	echo "Throttling kdump restart for concurrent udev event"
 	exit 0
 fi