Skip to content

Commit 3f6c16e

Browse files
liutgnucoiby
authored andcommitted
kdump test: output more useful info for users aware of
Resolves: RHEL-96907 Resolves: RHEL-96289 This patch have no functional change for kdumpctl test, but let it output more info to let users know. 1) Let "kdumpctl restart" to output the kdump test status: $ kdumpctl restart kdump: kexec: unloaded kdump kernel kdump: Stopping kdump: [OK] kdump: kexec: loaded kdump kernel kdump: Starting kdump: [OK] kdump: Notice: No vmcore creation test performed! 2) Output stderr when "reload" fails, which can help user to identify the failing root cause: $ echo 1 > /proc/sys/kernel/kexec_load_disabled $ kdumpctl test DANGER!!! Will perform a kdump test by crashing the system, proceed? (y/N): kdump: Start kdump test... kexec_file_load(unload) failed: Operation not permitted kdump: kexec: failed to unload kdump kernel kdump: Stopping kdump: [FAILED] kdump: Set kdump test id fail. Signed-off-by: Tao Liu <[email protected]>
1 parent ddb0bab commit 3f6c16e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

kdumpctl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1714,7 +1714,7 @@ set_kdump_test_id()
17141714

17151715
KDUMP_COMMANDLINE_APPEND+=" $_id "
17161716

1717-
if ! reload >&/dev/null; then
1717+
if ! reload > /dev/null; then
17181718
derror "Set kdump test id fail."
17191719
exit 1
17201720
fi
@@ -1931,6 +1931,7 @@ main()
19311931
derror "Starting kdump: [FAILED]"
19321932
exit 1
19331933
fi
1934+
check_vmcore_creation_status
19341935
;;
19351936
rebuild)
19361937
rebuild

0 commit comments

Comments
 (0)