Add ldap bind password lookup to chart

[tylerauerbeck]

We should add the lookup of the bind password value to the gitlab helper functions as this tends to cause an issue with user lookup if not set appropriately.

[jtudelag]

Hey @tylerauerbeck I have struggled to make the LDAP integration for Gitlab, I have realized there is kind a chicken egg problem with the bind password lookup and the secret. I think we might want to add a secret template in the chart, or just get rid od the secret Lookup and just pass the password directly as a variable in the Values file.

[tylerauerbeck]

@jtudelag The only issue I've seen is when I forget to update this secret name in the values file:
https://github.com/rht-labs/enablement-framework/blob/main/tooling/charts/do500/values.yaml#L47

In that case, since the dummy secret name I have there doesn't exist it returns a blank file (and then the gitlab configure has an empty bind password).

There shouldn't be too much of a chicken and the egg issue here becuase the bind password and secret are already created as part of the cluster deploy (so far before the gitlab or any of the other do500 components are ever stood up). Happy to take a look at this with you at some point though if there's just something else I haven't seen up to this point.

[jtudelag]

@jtudelag The only issue I've seen is when I forget to update this secret name in the values file:
https://github.com/rht-labs/enablement-framework/blob/main/tooling/charts/do500/values.yaml#L47

In that case, since the dummy secret name I have there doesn't exist it returns a blank file (and then the gitlab configure has an empty bind password).

There shouldn't be too much of a chicken and the egg issue here becuase the bind password and secret are already created as part of the cluster deploy (so far before the gitlab or any of the other do500 components are ever stood up). Happy to take a look at this with you at some point though if there's just something else I haven't seen up to this point.

Prob I did not explain myself correctly, my point is, assuming Gitlab Pod can only reference secrets within it's own namespace, and that NS is usually created by the DO500 chart, a secret with the bindPassword data should be part of the Gitlab manifests. I don't see how you can reference an already created secret in the cluster.

Am I talking non-sense??? 🙄