From 30151ddc5dd69b1279ac11acfbc76270b9a42719 Mon Sep 17 00:00:00 2001
From: Jacob See <jacob.d.see@gmail.com>
Date: Sun, 21 Jun 2020 14:10:46 -0700
Subject: [PATCH] Some cleanup

---
 .../pull-request-checks-disabled.yml          | 26 -----------------
 .github/workflows/pull-request-checks.yml     |  7 +----
 .github/workflows/release.yml                 | 28 -------------------
 deployment/templates/configmap.yaml           | 11 --------
 deployment/templates/deploymentconfig.yaml    | 11 --------
 5 files changed, 1 insertion(+), 82 deletions(-)
 delete mode 100644 .github/workflows/pull-request-checks-disabled.yml
 delete mode 100644 .github/workflows/release.yml
 delete mode 100644 deployment/templates/configmap.yaml

diff --git a/.github/workflows/pull-request-checks-disabled.yml b/.github/workflows/pull-request-checks-disabled.yml
deleted file mode 100644
index 6b36d05..0000000
--- a/.github/workflows/pull-request-checks-disabled.yml
+++ /dev/null
@@ -1,26 +0,0 @@
-name: PR check
-
-on:
-  pull_request:
-    paths:
-      - "!**"
-      - deployment/**
-      - design/**
-      - README.md
-
-jobs:
-  check-links:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Skip link check
-      run: echo "This check has been skipped because the only changes are in non-code directories."
-  linting:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Skip linting
-      run: echo "This check has been skipped because the only changes are in non-code directories."
-  build:
-    runs-on: ubuntu-latest
-    steps:
-    - name: Skip build
-      run: echo "This build has been skipped because the only changes are in non-code directories."
diff --git a/.github/workflows/pull-request-checks.yml b/.github/workflows/pull-request-checks.yml
index 6e6e46b..81631ae 100644
--- a/.github/workflows/pull-request-checks.yml
+++ b/.github/workflows/pull-request-checks.yml
@@ -1,11 +1,6 @@
 name: PR check
 
-on:
-  pull_request:
-    paths-ignore:
-      - deployment/**
-      - design/**
-      - README.md
+on: pull_request
 
 jobs:
   check-links:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
deleted file mode 100644
index 3c90184..0000000
--- a/.github/workflows/release.yml
+++ /dev/null
@@ -1,28 +0,0 @@
-name: Add Tags to Release
-
-on:
-  release:
-    types: [published]
-
-jobs:
-  release:
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-    - name: tag with release version
-      uses: tinact/docker.image-retag@1.0.2
-      with:
-        image_name: rht-labs/fee-fe
-        image_old_tag: ${{ github.sha }}
-        image_new_tag: ${{ github.event.release.tag_name }}
-        registry: quay.io
-        registry_username: ${{ secrets.QUAY_USERNAME }}
-        registry_password: ${{ secrets.QUAY_PASSWORD }}
-    - name: tag with latest
-      uses: tinact/docker.image-retag@1.0.2
-      with:
-        image_name: rht-labs/fee-fe
-        image_old_tag: ${{ github.sha }}
-        registry: quay.io
-        registry_username: ${{ secrets.QUAY_USERNAME }}
-        registry_password: ${{ secrets.QUAY_PASSWORD }}
diff --git a/deployment/templates/configmap.yaml b/deployment/templates/configmap.yaml
deleted file mode 100644
index 1fd72c8..0000000
--- a/deployment/templates/configmap.yaml
+++ /dev/null
@@ -1,11 +0,0 @@
-{{- if .Values.development }}
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: frontend-config
-data:
-  config.json: |
-    {
-      "baseUrl": "{{ .Values.baseUrl }}",
-    }
-{{- end }}
\ No newline at end of file
diff --git a/deployment/templates/deploymentconfig.yaml b/deployment/templates/deploymentconfig.yaml
index 05bb651..fe86c48 100644
--- a/deployment/templates/deploymentconfig.yaml
+++ b/deployment/templates/deploymentconfig.yaml
@@ -38,22 +38,11 @@ spec:
         resources: {}
         terminationMessagePath: /dev/termination-log
         terminationMessagePolicy: File
-        volumeMounts:
-        - name: config-volume
-          {{- if .Values.development }}
-          mountPath: /var/www/html/config
-          {{- else }}
-          mountPath: /opt/app-root/src/config
-          {{- end }}
       dnsPolicy: ClusterFirst
       restartPolicy: Always
       schedulerName: default-scheduler
       securityContext: {}
       terminationGracePeriodSeconds: 30
-      volumes:
-      - name: config-volume
-        configMap:
-          name: frontend-config
   triggers: 
   - type: ConfigChange
   - type: ImageChange