Skip to content

Commit e059098

Browse files
authored
Merge pull request #7 from mcanoy/dev-services
up quarkus to 2.0.2 and leverage mongo devservices for dev and test
2 parents 7d761ac + 738646e commit e059098

File tree

7 files changed

+7
-108
lines changed

7 files changed

+7
-108
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ See the deployment [readme](./deployment) for information on deploying to a Open
3636

3737
### MongoDB
3838

39-
A MongoDB database is needed for development. To spin up a docker MongoDB container run the following
39+
A MongoDB database is needed for development and is automatically added by Quarkus Devservices. To use a different instance, run in prod mode and point to the mongo instance via properties. To create a docker instance, run the following
4040

4141
```
4242
cd deployment

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
<maven.compiler.target>11</maven.compiler.target>
1515
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1616
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
17-
<quarkus-plugin.version>1.13.7.Final</quarkus-plugin.version>
17+
<quarkus-plugin.version>2.0.2.Final</quarkus-plugin.version>
1818
<quarkus.platform.artifact-id>quarkus-universe-bom</quarkus.platform.artifact-id>
1919
<quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
20-
<quarkus.platform.version>1.13.7.Final</quarkus.platform.version>
20+
<quarkus.platform.version>2.0.2.Final</quarkus.platform.version>
2121
<surefire-plugin.version>3.0.0-M5</surefire-plugin.version>
2222
<wiremock.version>2.28.1</wiremock.version>
2323
<javers.core.version>6.2.2</javers.core.version>

src/main/resources/application.properties

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,12 @@ quarkus.package.type=uber-jar
1313
quarkus.swagger-ui.always-include=true
1414

1515
# Configure your datasource
16-
mongo.user=${MONGODB_USER:mongouser}
17-
mongo.password=${MONGODB_PASSWORD:mongopassword}
18-
mongo.service.name=${DATABASE_SERVICE_NAME:localhost:27017}
16+
%prod.mongo.user=${MONGODB_USER:mongouser}
17+
%prod.mongo.password=${MONGODB_PASSWORD:mongopassword}
18+
%prod.mongo.service.name=${DATABASE_SERVICE_NAME:localhost:27017}
1919
quarkus.mongodb.database=${MONGODB_DATABASE:artifacts}
2020

21-
quarkus.mongodb.connection-string=mongodb://${mongo.user}:${mongo.password}@${mongo.service.name}/${quarkus.mongodb.database}?uuidRepresentation=javaLegacy
22-
%dev.quarkus.mongodb.connection-string=mongodb://${mongo.user}:${mongo.password}@${mongo.service.name}/${quarkus.mongodb.database}?uuidRepresentation=javaLegacy&authSource=admin
23-
24-
%test.quarkus.mongodb.connection-string=mongodb://${mongo.service.name}/${quarkus.mongodb.database}?uuidRepresentation=javaLegacy
25-
%test.quarkus.mongodb.write-concern.journal=false
21+
%prod.quarkus.mongodb.connection-string=mongodb://${mongo.user}:${mongo.password}@${mongo.service.name}/${quarkus.mongodb.database}?uuidRepresentation=javaLegacy
2622

2723
# GitLab API properties
2824
gitlab.api/mp-rest/scope=javax.inject.Singleton
@@ -33,7 +29,6 @@ engagement.api/mp-rest/url=${ENGAGEMENT_API_URL:http://git-api:8080}
3329
mp.openapi.extensions.smallrye.info.title=LodeStar Artifacts API
3430
quarkus.swagger-ui.theme=muted
3531

36-
3732
gitlab.personal.access.token=${GITLAB_TOKEN:t}
3833

3934
# Application

src/test/java/com/redhat/labs/model/ArtifactTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,11 @@
1313
import com.redhat.labs.lodestar.model.Artifact;
1414
import com.redhat.labs.lodestar.service.ArtifactService;
1515
import com.redhat.labs.mock.ExternalApiWireMock;
16-
import com.redhat.labs.mongo.MongoTestResource;
1716

1817
import io.quarkus.test.common.QuarkusTestResource;
1918
import io.quarkus.test.junit.QuarkusTest;
2019

2120
@QuarkusTest
22-
@QuarkusTestResource(MongoTestResource.class)
2321
@QuarkusTestResource(ExternalApiWireMock.class)
2422
class ArtifactTest {
2523

src/test/java/com/redhat/labs/mongo/MongoTestResource.java

Lines changed: 0 additions & 90 deletions
This file was deleted.

src/test/java/com/redhat/labs/resource/ArtifactResourceTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,13 @@
2020
import com.redhat.labs.lodestar.model.GetListOptions;
2121
import com.redhat.labs.lodestar.service.ArtifactService;
2222
import com.redhat.labs.mock.ExternalApiWireMock;
23-
import com.redhat.labs.mongo.MongoTestResource;
2423

2524
import io.quarkus.test.common.QuarkusTestResource;
2625
import io.quarkus.test.junit.QuarkusTest;
2726
import io.restassured.http.ContentType;
2827
import io.restassured.path.json.JsonPath;
2928

3029
@QuarkusTest
31-
@QuarkusTestResource(MongoTestResource.class)
3230
@QuarkusTestResource(ExternalApiWireMock.class)
3331
class ArtifactResourceTest {
3432

src/test/java/com/redhat/labs/service/ArtifactServiceTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@
2323
import com.redhat.labs.lodestar.service.ArtifactService;
2424
import com.redhat.labs.mock.ExternalApiWireMock;
2525
import com.redhat.labs.mock.ResourceLoader;
26-
import com.redhat.labs.mongo.MongoTestResource;
2726

2827
import io.quarkus.test.common.QuarkusTestResource;
2928
import io.quarkus.test.junit.QuarkusTest;
3029

3130
@QuarkusTest
32-
@QuarkusTestResource(MongoTestResource.class)
3331
@QuarkusTestResource(ExternalApiWireMock.class)
3432
class ArtifactServiceTest {
3533

0 commit comments

Comments
 (0)