fix count of participants when getting all engagements (#171)

Author: mcanoy

src/main/java/com/redhat/labs/lodestar/resource/EngagementResource.java

@@ -315,6 +315,7 @@ public Response post(@Valid Engagement engagement, @Context UriInfo uriInfo) {
 
         // create the resource
         Engagement created = engagementService.create(engagement);
+        LOGGER.debug("New Engagement {}", created);
 
         // build location response
         UriBuilder builder = uriInfo.getAbsolutePathBuilder();
@@ -360,7 +361,6 @@ public Response put(@PathParam("customerName") String customerName, @PathParam("
     @Operation(summary = "Updates the engagement resource in the database.")
     public Response put(@PathParam("id") String uuid, @Valid Engagement engagement) {
 
-
         boolean writer = jwtUtils.isAllowedToWriteEngagement(jwt, configService.getPermission(engagement.getType()));
         if(!writer) {
             return forbiddenResponse(engagement.getType());

src/main/java/com/redhat/labs/lodestar/service/EngagementService.java

@@ -209,6 +209,8 @@ public Engagement update(Engagement engagement) {
         //TODO update cache
         if(somethingChanged) {
             engagementApiClient.registerUpdate(engagementUuid);
+        } else {
+            LOGGER.debug("Nothing changed for {}", engagementUuid);
         }
         return getEngagement(engagementUuid);
     }
@@ -343,8 +345,9 @@ public Response getEngagementsPaged(ListFilterOptions listFilterOptions) {
         //TODO this loop is to allow frontend to change after v2 deployment.
         // FE should use participant, artifact count field, and categories (string version)
         for(Engagement e : engagements) {
+
             for(int i=0; i<e.getParticipantCount(); i++) {
-                e.addParticipant(new EngagementUser());
+                e.addParticipant(EngagementUser.builder().email(String.valueOf(i)).build());
             }
 
             for(int i=0; i<e.getArtifactCount(); i++) {

src/test/java/com/redhat/labs/lodestar/resource/EngagementResourceGetTest.java

@@ -112,8 +112,10 @@ void testGetEngagementsSuccessNoEngagements() {
     @Test
     void testGetEngagementsSuccess() {
 
-        Engagement engagement1 = Engagement.builder().uuid("1234").type("Residency").customerName("Customer").projectName("Project1").build();
-        Engagement engagement2 = Engagement.builder().uuid("1235").type("Residency").customerName("Customer").projectName("Project2").build();
+        Engagement engagement1 = Engagement.builder().uuid("1234").type("Residency").customerName("Customer").projectName("Project1")
+                .artifactCount(4).build();
+        Engagement engagement2 = Engagement.builder().uuid("1235").type("Residency").customerName("Customer").projectName("Project2")
+                .participantCount(10).build();
 
         Mockito.when(engagementApiClient.getEngagements(0, 500, Collections.emptySet())).thenReturn(Response.ok(List.of(engagement1, engagement2)).build());
 
@@ -126,7 +128,9 @@ void testGetEngagementsSuccess() {
                 .get("/engagements")
             .then()
                 .statusCode(200)
-                .body("size()", equalTo(2));
+                .body("size()", equalTo(2))
+                .body("[1].engagement_users.size()", equalTo(10))
+                .body("[0].artifacts.size()", equalTo(4));
 
         Mockito.verify(engagementApiClient).getEngagements(0, 500, Collections.emptySet());
     }