Skip to content

Commit 9f383f5

Browse files
authored
filter engagement counts by region (#180)
1 parent 86b80a5 commit 9f383f5

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

src/main/java/com/redhat/labs/lodestar/resource/EngagementResource.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,11 +100,11 @@ public Response getAll(@Context UriInfo uriInfo, @BeanParam ListFilterOptions fi
100100
@APIResponses(value = { @APIResponse(responseCode = "401", description = "Missing or Invalid JWT"),
101101
@APIResponse(responseCode = "200", description = "Engagement counts computed.") })
102102
@Operation(summary = "Gets a map of engagement counts by status")
103-
public Map<EngagementState, Integer> countByStatus(@QueryParam(value = "localTime") String localTime) {
103+
public Map<EngagementState, Integer> countByStatus(@QueryParam(value = "localTime") String localTime, @QueryParam("region") Set<String> regions) {
104104

105105
Instant currentTime = localTime == null ? Instant.now() : Instant.parse(localTime);
106106

107-
return engagementService.getEngagementCountByStatus(currentTime);
107+
return engagementService.getEngagementCountByStatus(currentTime, regions);
108108
}
109109

110110
//TODO metrics is saying this is not called

src/main/java/com/redhat/labs/lodestar/rest/client/EngagementApiClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public interface EngagementApiClient {
2222
//TODO support time shifting
2323
@GET
2424
@Path("count")
25-
Map<Engagement.EngagementState, Integer> getEngagementCounts();
25+
Map<Engagement.EngagementState, Integer> getEngagementCounts(@QueryParam("region") Set<String> region);
2626

2727
@GET
2828
@Path("category/{category}")

src/main/java/com/redhat/labs/lodestar/service/EngagementService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,8 @@ public Engagement getByProjectId(int projectId) {
313313
return engagementApiClient.getEngagementByProject(projectId);
314314
}
315315

316-
public Map<EngagementState, Integer> getEngagementCountByStatus(Instant currentTime) {
317-
return engagementApiClient.getEngagementCounts();
316+
public Map<EngagementState, Integer> getEngagementCountByStatus(Instant currentTime, Set<String> regions) {
317+
return engagementApiClient.getEngagementCounts(regions);
318318
}
319319

320320
/**

src/test/java/com/redhat/labs/lodestar/resource/EngagementResourceCountTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import static io.restassured.RestAssured.given;
44
import static org.hamcrest.CoreMatchers.equalTo;
55

6+
import java.util.Collections;
67
import java.util.HashMap;
78
import java.util.Map;
89

@@ -41,7 +42,7 @@ void resourceCount() {
4142
counts.put(Engagement.EngagementState.PAST, 2);
4243
counts.put(Engagement.EngagementState.ANY, 42);
4344

44-
Mockito.when(engagementApiClient.getEngagementCounts()).thenReturn(counts);
45+
Mockito.when(engagementApiClient.getEngagementCounts(Collections.emptySet())).thenReturn(counts);
4546

4647
given().when().auth().oauth2(token).get(url).then().statusCode(200).body("UPCOMING", equalTo(16))
4748
.body("ACTIVE", equalTo(8))

0 commit comments

Comments
 (0)