Skip to content

Commit 0a66970

Browse files
authored
leverage engagement pretty print. leverage participant + artifact counts (#582)
1 parent 66f3326 commit 0a66970

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

src/components/engagement_list_item/engagement_at_a_glance.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ export function EngagementAtAGlance({
6060
/>
6161
</GridItem>
6262
<GridItem>
63-
{engagement?.engagement_type
63+
{engagement?.pretty_type
6464
? 'Engagement Type: ' +
65-
engagement?.engagement_type
65+
engagement?.pretty_type
6666
: null}
6767
</GridItem>
6868
<GridItem>

src/components/engagement_list_item/mock_engagements.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export function upcomingEngagement(): Engagement {
1313
engagement_lead_email: '[email protected]',
1414
engagement_lead_name: `Alice Doe`,
1515
engagement_type: 'Residency',
16+
pretty_type: 'Residency',
1617
location: `Nashville, TN`,
1718
ocp_cloud_provider_name: 'AWS',
1819
ocp_cloud_provider_region: 'N. Virginia',
@@ -53,6 +54,7 @@ export function currentEngagement(): Engagement {
5354
engagement_lead_email: '[email protected]',
5455
engagement_lead_name: `Alice Doe`,
5556
engagement_type: 'Residency',
57+
pretty_type: 'Residency',
5658
location: `Nashville, TN`,
5759
ocp_cloud_provider_name: 'AWS',
5860
ocp_cloud_provider_region: 'N. Virginia',
@@ -96,6 +98,7 @@ export function pastEngagement(): Engagement {
9698
engagement_lead_email: '[email protected]',
9799
engagement_lead_name: `Alice Doe`,
98100
engagement_type: 'Residency',
101+
pretty_type: 'Residency',
99102
location: `Nashville, TN`,
100103
ocp_cloud_provider_name: 'AWS',
101104
ocp_cloud_provider_region: 'N. Virginia',

src/schemas/engagement.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,14 @@ export interface EngagementOverview {
8585
project_name: string;
8686
customer_name: string;
8787
engagement_type: string;
88+
pretty_type: string;
8889
description: string;
8990
public_reference: boolean;
9091
engagement_categories: EngagementCategory[];
9192
engagement_region: string;
9293
timezone?: string;
94+
artifact_count: number;
95+
participant_count: number;
9396
}
9497

9598
export interface EngagementHistory {
@@ -226,6 +229,7 @@ export abstract class Engagement {
226229
? 'Alice Doe'
227230
: `${faker.name.firstName()} ${faker.name.lastName()}`,
228231
engagement_type: 'Residency',
232+
pretty_type: 'Residency',
229233
last_update: staticData ? new Date(2020, 1, 1, 1, 1, 1, 1) : new Date(),
230234
location: staticData
231235
? 'Nashville, TN'
@@ -285,6 +289,8 @@ export abstract class Engagement {
285289
uuid: staticData ? 'uuid' : faker.random.uuid(),
286290
writeable: false,
287291
timezone: 'Americas/Denver',
292+
artifact_count: 0,
293+
participant_count: 0,
288294
};
289295
}
290296
}

src/serializers/engagement/engagement_json_serializer.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ export class EngagementJsonSerializer
124124
engagement_lead_email: data['engagement_lead_email'],
125125
engagement_lead_name: data['engagement_lead_name'],
126126
engagement_type: data['engagement_type'],
127+
pretty_type: data['pretty_type'],
127128
hosting_environments:
128129
data['hosting_environments']?.map?.(
129130
EngagementJsonSerializer.deserializeHostingEnvironment
@@ -144,6 +145,8 @@ export class EngagementJsonSerializer
144145
last_update_by_name: data['last_update_by_name'],
145146
engagement_categories: data['engagement_categories'],
146147
timezone: data['timezone'],
148+
artifact_count: data['artifact_count'],
149+
participant_count: data['participant_count'],
147150
};
148151
}
149152

0 commit comments

Comments
 (0)