Make the 'View Engagement' link right clickable (#589)

Author: mcanoy

src/components/engagement_list/__tests__/__snapshots__/engagement_list.spec.tsx.snap

@@ -221,17 +221,17 @@ Object {
             <div
               class="pf-l-grid__item pf-m-12-col-on-sm pf-m-4-col-on-md pf-m-2-col-on-lg"
             >
-              <button
+              <a
                 aria-disabled="false"
                 class="pf-c-button pf-m-secondary"
                 data-cy="view_engagement_button"
                 data-ouia-component-id="OUIA-Generated-Button-secondary-1"
                 data-ouia-component-type="PF4/Button"
                 data-ouia-safe="true"
-                type="button"
+                href="/app/engagements/uuid"
               >
                 View Engagement
-              </button>
+              </a>
             </div>
           </div>
         </div>
@@ -455,17 +455,17 @@ Object {
           <div
             class="pf-l-grid__item pf-m-12-col-on-sm pf-m-4-col-on-md pf-m-2-col-on-lg"
           >
-            <button
+            <a
               aria-disabled="false"
               class="pf-c-button pf-m-secondary"
               data-cy="view_engagement_button"
               data-ouia-component-id="OUIA-Generated-Button-secondary-1"
               data-ouia-component-type="PF4/Button"
               data-ouia-safe="true"
-              type="button"
+              href="/app/engagements/uuid"
             >
               View Engagement
-            </button>
+            </a>
           </div>
         </div>
       </div>
@@ -746,17 +746,17 @@ Object {
             <div
               class="pf-l-grid__item pf-m-12-col-on-sm pf-m-4-col-on-md pf-m-2-col-on-lg"
             >
-              <button
+              <a
                 aria-disabled="false"
                 class="pf-c-button pf-m-secondary"
                 data-cy="view_engagement_button"
                 data-ouia-component-id="OUIA-Generated-Button-secondary-1"
                 data-ouia-component-type="PF4/Button"
                 data-ouia-safe="true"
-                type="button"
+                href="/app/engagements/uuid"
               >
                 View Engagement
-              </button>
+              </a>
             </div>
           </div>
         </div>

src/components/engagement_list_item/__tests__/__snapshots__/engagement_list_item.spec.tsx.snap

@@ -221,17 +221,17 @@ Object {
             <div
               class="pf-l-grid__item pf-m-12-col-on-sm pf-m-4-col-on-md pf-m-2-col-on-lg"
             >
-              <button
+              <a
                 aria-disabled="false"
                 class="pf-c-button pf-m-secondary"
                 data-cy="view_engagement_button"
                 data-ouia-component-id="OUIA-Generated-Button-secondary-1"
                 data-ouia-component-type="PF4/Button"
                 data-ouia-safe="true"
-                type="button"
+                href="/app/engagements/uuid"
               >
                 View Engagement
-              </button>
+              </a>
             </div>
           </div>
         </div>
@@ -455,17 +455,17 @@ Object {
           <div
             class="pf-l-grid__item pf-m-12-col-on-sm pf-m-4-col-on-md pf-m-2-col-on-lg"
           >
-            <button
+            <a
               aria-disabled="false"
               class="pf-c-button pf-m-secondary"
               data-cy="view_engagement_button"
               data-ouia-component-id="OUIA-Generated-Button-secondary-1"
               data-ouia-component-type="PF4/Button"
               data-ouia-safe="true"
-              type="button"
+              href="/app/engagements/uuid"
             >
               View Engagement
-            </button>
+            </a>
           </div>
         </div>
       </div>

src/components/engagement_list_item/__tests__/__snapshots__/engagement_list_item_card.spec.tsx.snap

@@ -221,17 +221,17 @@ Object {
             <div
               class="pf-l-grid__item pf-m-12-col-on-sm pf-m-4-col-on-md pf-m-2-col-on-lg"
             >
-              <button
+              <a
                 aria-disabled="false"
                 class="pf-c-button pf-m-secondary"
                 data-cy="view_engagement_button"
                 data-ouia-component-id="OUIA-Generated-Button-secondary-2"
                 data-ouia-component-type="PF4/Button"
                 data-ouia-safe="true"
-                type="button"
+                href="/app/engagements/uuid"
               >
                 View Engagement
-              </button>
+              </a>
             </div>
           </div>
         </div>
@@ -455,17 +455,17 @@ Object {
           <div
             class="pf-l-grid__item pf-m-12-col-on-sm pf-m-4-col-on-md pf-m-2-col-on-lg"
           >
-            <button
+            <a
               aria-disabled="false"
               class="pf-c-button pf-m-secondary"
               data-cy="view_engagement_button"
               data-ouia-component-id="OUIA-Generated-Button-secondary-2"
               data-ouia-component-type="PF4/Button"
               data-ouia-safe="true"
-              type="button"
+              href="/app/engagements/uuid"
             >
               View Engagement
-            </button>
+            </a>
           </div>
         </div>
       </div>

src/components/engagement_list_item/engagement_list_item.tsx

@@ -68,11 +68,10 @@ export function EngagementListItem(props: DataCardProps) {
             </GridItem>
             <GridItem sm={12} md={4} lg={2}>
               <Button
-                onClick={() => {
-                  history.push(url);
-                }}
+                href = { url }
                 variant="secondary"
-                data-cy={'view_engagement_button'}
+                data-cy="view_engagement_button"
+                component="a"
               >
                 View Engagement
               </Button>