error handling when renaming engagement. Remove edit message for read… (#607)

* error handling when renaming engagement. Remove edit message for read only user

* fix new engagement exception. Cleanup bits

* move to node 14

Author: mcanoy

.github/workflows/pull-request-checks.yml

@@ -35,7 +35,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [12.x]
+        node-version: [14.x]
     steps:
       - name: Download build artifact
         uses: actions/download-artifact@v2

src/components/engagement_data_cards/__tests__/__snapshots__/data_cards.spec.tsx.snap

@@ -856,11 +856,7 @@ Object {
               </h5>
               <div
                 class="pf-c-empty-state__body"
-              >
-                <p>
-                  Click the 'Edit' button, to begin adding point of contacts
-                </p>
-              </div>
+              />
             </div>
           </div>
         </div>
@@ -938,11 +934,7 @@ Object {
             </h5>
             <div
               class="pf-c-empty-state__body"
-            >
-              <p>
-                Click the 'Edit' button, to begin adding point of contacts
-              </p>
-            </div>
+            />
           </div>
         </div>
       </div>

src/components/engagement_data_cards/engagement_summary_card/engagement_summary_card.tsx

@@ -150,7 +150,7 @@ export function EngagementSummaryCard() {
                 <TitledDataPoint title="Use Cases" dataCy={'use_cases'}>
                   <>
                     {currentEngagement?.use_cases?.map?.(useCase => (
-                      <p key={useCase.id ?? useCase.description}>
+                      <p key={useCase.uuid ?? useCase.description}>
                         {useCase.description}
                       </p>
                     ))}

src/components/engagement_data_cards/point_of_contact_card/point_of_contact_card.tsx

@@ -101,7 +101,9 @@ export function PointOfContactCard() {
               No Points of Contact Added
             </Title>
             <EmptyStateBody>
-              <p>Click the 'Edit' button, to begin adding point of contacts</p>
+              <Feature name="writer">
+                <p>Click the 'Edit' button, to begin adding point of contacts</p>
+              </Feature>
             </EmptyStateBody>
           </EmptyState>
         )}

src/context/engagement_context/engagement_context.tsx

@@ -11,6 +11,7 @@ import { EngagementFormConfig } from '../../schemas/engagement_config';
 import {
   AlreadyExistsError,
   AlreadyLaunchedError,
+  NamingError,
   NotFoundError,
 } from '../../services/engagement_service/engagement_service_errors';
 import {
@@ -204,7 +205,7 @@ export const EngagementProvider = ({
             const hasUpdates = await _checkHasUpdateRef.current();
             if (hasUpdates) {
               feedbackContext.showAlert(
-                'Another user edited this engagement. In order to continue, you must refresh the page. By refreshing, your unsaved changes will be overwritten."',
+                'Another user edited this engagement. In order to continue, you must refresh the page. By refreshing, your unsaved changes will be overwritten.',
                 AlertType.error,
                 false,
                 [
@@ -412,18 +413,8 @@ export const EngagementProvider = ({
         feedbackContext.hideLoader();
         let errorMessage =
           'There was an issue with saving your changes. Please follow up with an administrator if this continues.';
-        if (e instanceof AlreadyExistsError) {
-          // If there is no mongo id associated with the engagement, then it is being committed to the backend for the first time. It is a net new engagement.
-          if (!!data.mongo_id) {
-            errorMessage =
-              'The path that you input is already taken.  Please update and try saving again.';
-
-            // Otherwise, we are saving an existing engagement.
-          } else {
-            _handleErrors(e);
-            errorMessage =
-              'Your changes could not be saved. Another user has modified this data. Please refresh your data in order to make changes.';
-          }
+        if (e instanceof AlreadyExistsError || e instanceof NamingError) {
+          errorMessage = e.message;
         }
         feedbackContext.showAlert(errorMessage, AlertType.error);
       }
@@ -432,7 +423,6 @@ export const EngagementProvider = ({
       feedbackContext,
       currentEngagementChanges,
       engagementService,
-      _handleErrors,
       changedGroups,
       setCurrentEngagement,
     ]

src/packages/api_v1_sdk/apiv1_engagement_service.ts

@@ -4,7 +4,7 @@ import {
 } from '../../services/engagement_service/engagement_service';
 import { Engagement } from '../../schemas/engagement';
 import { EngagementFormConfig } from '../../schemas/engagement_config';
-import { AlreadyExistsError } from '../../services/engagement_service/engagement_service_errors';
+import { AlreadyExistsError, NamingError } from '../../services/engagement_service/engagement_service_errors';
 import { EngagementJsonSerializer } from '../../serializers/engagement/engagement_json_serializer';
 import { Logger } from '../../utilities/logger';
 import { handleAxiosResponseErrors } from './http_error_handlers';
@@ -17,13 +17,15 @@ export class Apiv1EngagementService implements EngagementService {
     this.axios = getApiV1HttpClient();
     this.getEngagementById = this.getEngagementById.bind(this);
   }
+
   async checkSubdomainUniqueness(subdomain: string): Promise<boolean> {
     return this.axios
       .head(`/engagements/subdomain/${subdomain}`)
       .then(() => true)
       .catch(() => false);
   }
   private static engagementSerializer = new EngagementJsonSerializer();
+
   private buildQueryStringFromParameters(
     parameters: EngagementSearchParameters
   ): string {
@@ -115,7 +117,7 @@ export class Apiv1EngagementService implements EngagementService {
       Logger.instance.error(e);
       if (e.response.status === 409) {
         throw new AlreadyExistsError(
-          'A project with this customer name and project name already exists'
+          'A project with this customer name and project name already exists 👀'
         );
       }
       if (e.isAxiosError) {
@@ -142,6 +144,24 @@ export class Apiv1EngagementService implements EngagementService {
       return Apiv1EngagementService.engagementSerializer.deserialize(data);
     } catch (e) {
       if (e.isAxiosError) {
+        if(e.response.status === 400 && e.response.data["parameter_violations"]) {
+          const errorMessage = e.response.data["parameter_violations"][0];
+          let field = "Parameter";
+          if(errorMessage.path === 'put.engagement.customerName') {
+            field = "Client name";
+          } else if(errorMessage.path === 'put.engagement.name') {
+            field = 'Engagement name';
+          }
+          throw new NamingError(
+            `${field} value ${errorMessage.value} is invalid. 😔 ${errorMessage.message}`
+          );
+        }
+
+        if (e.response.status === 409) {
+          throw new AlreadyExistsError(
+            'A project with this customer name and project name already exists 👀'
+          );
+        }
         handleAxiosResponseErrors(e);
       } else {
         throw e;

src/routes/create_new_engagement/create_new_engagement.tsx

@@ -78,59 +78,64 @@ export function CreateNewEngagementForm() {
   }, [selectedProjectNameToFind, engagements]);
 
   const submitNewEngagement = async () => {
-    if (customerName && projectName) {
-      if (selectedProjectNameToFind) {
-        const result = await createEngagement({
-          customer_name: customerName,
-          project_name: projectName,
-          engagement_region: region,
-          engagement_type:
-            engagementType ??
-            engagementFormConfig?.basic_information?.engagement_types?.options?.find?.(
-              e => e.default
-            )?.value,
-          engagement_categories: copiedEngagement?.engagement_categories,
-          hosting_environments: copiedEngagement?.hosting_environments.map(
-            hosting_env => {
-              return {
-                ocp_cloud_provider_name: hosting_env.ocp_cloud_provider_name,
-                ocp_cloud_provider_region:
-                  hosting_env.ocp_cloud_provider_region,
-                ocp_cluster_size: hosting_env.ocp_cluster_size,
-                ocp_persistent_storage_size:
-                  hosting_env.ocp_persistent_storage_size,
-                ocp_version: hosting_env.ocp_version,
-              };
-            }
-          ),
+    try {
+      if (customerName && projectName) {
+        if (selectedProjectNameToFind) {
+          const result = await createEngagement({
+            customer_name: customerName,
+            project_name: projectName,
+            engagement_region: region,
+            engagement_type:
+              engagementType ??
+              engagementFormConfig?.basic_information?.engagement_types?.options?.find?.(
+                e => e.default
+              )?.value,
+            engagement_categories: copiedEngagement?.engagement_categories,
+            hosting_environments: copiedEngagement?.hosting_environments.map(
+              hosting_env => {
+                return {
+                  ocp_cloud_provider_name: hosting_env.ocp_cloud_provider_name,
+                  ocp_cloud_provider_region:
+                    hosting_env.ocp_cloud_provider_region,
+                  ocp_cluster_size: hosting_env.ocp_cluster_size,
+                  ocp_persistent_storage_size:
+                    hosting_env.ocp_persistent_storage_size,
+                  ocp_version: hosting_env.ocp_version,
+                };
+              }
+            ),
+          });
+          uuid = result.uuid;
+        } else {
+          const result = await createEngagement({
+            customer_name: customerName,
+            project_name: projectName,
+            engagement_region: region,
+            engagement_type:
+              engagementType ??
+              engagementFormConfig?.basic_information?.engagement_types?.options?.find?.(
+                e => e.default
+              )?.value,
+            timezone: getTimeZone(),
+          });
+          uuid = result.uuid;
+        }
+        // want to inject uuid from the post return here
+        logEvent({
+          action: 'Create New Engagement',
+          category: AnalyticsCategory.engagements,
         });
-        uuid = result.uuid;
-      } else {
-        const result = await createEngagement({
-          customer_name: customerName,
-          project_name: projectName,
-          engagement_region: region,
-          engagement_type:
-            engagementType ??
-            engagementFormConfig?.basic_information?.engagement_types?.options?.find?.(
-              e => e.default
-            )?.value,
-          timezone: getTimeZone(),
+        
+        history.push({
+          pathname: `/app/engagements/${uuid}`,
         });
-        uuid = result.uuid;
+      } else {
+        history.push('/app/engagements');
       }
-      // want to inject uuid from the post return here
-      logEvent({
-        action: 'Create New Engagement',
-        category: AnalyticsCategory.engagements,
-      });
-      
-      history.push({
-        pathname: `/app/engagements/${uuid}`,
-      });
-    } else {
-      history.push('/app/engagements');
+    } catch(e) {
+      console.log('something went wrong while creating the engagement', e);
     }
+    
   };
 
   const [hasFetchedEngagements, setHasFetchedEngagements] = useState<boolean>(

src/services/engagement_service/engagement_service_errors.ts

@@ -1,3 +1,4 @@
 export class AlreadyExistsError extends Error {}
+export class NamingError extends Error {}
 export class AlreadyLaunchedError extends Error {}
 export class NotFoundError extends Error {}