Merge pull request #87 from dwasinge/perf

GET All Engagements - Performance Improvements Part 1: Use Parallel Stream

Author: mcanoy

src/main/java/com/redhat/labs/omp/service/EngagementService.java

@@ -4,6 +4,7 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
+import java.util.stream.Collectors;
 
 import javax.annotation.PostConstruct;
 import javax.enterprise.context.ApplicationScoped;
@@ -178,19 +179,20 @@ public List<Engagement> getAllEngagements() {
 
         List<Project> projects = projectService.getProjectsByGroup(engagementRepositoryId, true);
 
-        List<Engagement> engagementList = new ArrayList<>();
+        return
+            projects
+                .parallelStream()
+                .map(project -> {
+                    return getEngagement(project, true);
+                })
+                .filter(optional -> optional.isPresent())
+                .map(optional -> {
+                    return optional.get();
+                })
+                .collect(Collectors.toList());
 
-        for (Project project : projects) {
-            LOGGER.debug("project id {}", project.getId());
-            Optional<Engagement> engagement = getEngagement(project, true);
-            if(engagement.isPresent() ) {
-                engagementList.add(engagement.get());
-            }
-        }
-
-        return engagementList;
     }
-    
+
     public Engagement getEngagement(String namespaceOrId, boolean includeStatus) {
         Engagement engagement = null;